openstack/manila
Code Issues Proposed changes

Merge "Stop logging sensitive login information"

Browse Source
This commit is contained in:
Zuul 2022-07-05 17:48:46 +00:00 committed by Gerrit Code Review
commit cbe2b067af
2 changed files with 6 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
manila/utils.py
View File

@ -139,14 +139,10 @@ class SSHPool(pools.Pool):
elif self.password: elif self.password:
look_for_keys = False look_for_keys = False
try: try:
LOG.debug("ssh.connect: ip: %s, port: %s, username: %s, " LOG.debug("ssh.connect: ip: %s, port: %s, look_for_keys: %s, "
"password: %s, key_filename: %s, look_for_keys: %s, "
"timeout: %s, banner_timeout: %s", "timeout: %s, banner_timeout: %s",
self.ip, self.ip,
self.port, self.port,
self.login,
self.password,
self.path_to_private_key,
look_for_keys, look_for_keys,
self.conn_timeout, self.conn_timeout,
self.conn_timeout) self.conn_timeout)

5
releasenotes/notes/bug-1976370-stop-logging-login-information-b726d05ee805df27.yaml Normal file
View File

@ -0,0 +1,5 @@
---
security:
- |
The SSH utility module no longer logs usernames and passwords as
debug information.