openstack/manila
Code Issues Proposed changes

Merge "Trivial fix LOG.exception issues"

Browse Source
This commit is contained in:
Jenkins
2017-01-05 17:07:57 +00:00
committed by Gerrit Code Review
parent 3b540f0807 f775c81c89
commit d1ef0f2ce7
18 changed files with 88 additions and 104 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
manila/share/drivers/helpers.py
View File

@@ -379,10 +379,9 @@ class CIFSHelperIPAccess(NASHelperBase):
# Share does not exist, create it
try:
self._ssh_exec(server, create_cmd)
except Exception as child_e:
except Exception:
msg = _("Could not create CIFS export %s.") % share_name
LOG.exception(child_e)
LOG.error(msg)
LOG.exception(msg)
raise exception.ManilaException(reason=msg)
else:
# Share exists
@@ -391,10 +390,9 @@ class CIFSHelperIPAccess(NASHelperBase):
server, ['sudo', 'net', 'conf', 'delshare', share_name, ])
try:
self._ssh_exec(server, create_cmd)
except Exception as e:
except Exception:
msg = _("Could not create CIFS export %s.") % share_name
LOG.exception(e)
LOG.error(msg)
LOG.exception(msg)
raise exception.ManilaException(reason=msg)
else:
msg = _('Share section %s already defined.') % share_name