openstack
/
manila
Code Issues Proposed changes

Fix response code for various NotFound exceptions 

Fix response code for "NotFound"-like Manila exceptions.

- StorageResourceNotFound
- SnapshotNotFound
- ShareResourceNotFound

Change-Id: Ic7be15c2f8951e512de88d1f559ec677ba4bd78e
Closes-Bug: #1525860
This commit is contained in:
daiki kato 2015-12-25 07:25:12 +00:00
parent 2cc722e125
commit d29e611c2f
2 changed files with 17 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
manila/exception.py
View File

@ -565,6 +565,7 @@ class StorageResourceException(ManilaException):
class StorageResourceNotFound(StorageResourceException):
message = _("Storage resource %(name)s not found.")
code = 404
class SnapshotNotFound(StorageResourceNotFound):

18
manila/tests/test_exception.py
View File

@ -448,11 +448,25 @@ class ManilaExceptionResponseCode404(test.TestCase):
self.assertEqual(404, e.code)
self.assertIn(instance_id, e.msg)
def test_storage_resource_not_found(self):
# verify response code for exception.StorageResourceNotFound
name = "fake_name"
e = exception.StorageResourceNotFound(name=name)
self.assertEqual(404, e.code)
self.assertIn(name, e.msg)
def test_snapshot_not_found(self):
# verify response code for exception.SnapshotNotFound
name = "fake_name"
e = exception.SnapshotNotFound(name=name)
self.assertEqual(404, e.code)
self.assertIn(name, e.msg)
def test_share_resource_not_found(self):
# verify response code for exception.ShareNotFound
# verify response code for exception.ShareResourceNotFound
share_id = "fake_share_id"
e = exception.ShareResourceNotFound(share_id=share_id)
self.assertEqual(500, e.code)
self.assertEqual(404, e.code)
self.assertIn(share_id, e.msg)