openstack
/
manila
Code Issues Proposed changes

Use list values for cephfs_ganesha_export_ips 

... because the parameter is defined as ListOpt. A string value is
automatically converted by oslo.config so the current usage does not
cause actual issue but quite confusing.

Change-Id: Id97c5ef3da2db678bf30ef2deb25a159f8af08c4
This commit is contained in:
Takashi Kajinami 2022-04-11 10:43:54 +09:00
parent cbf142912d
commit d951b4713c
2 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
manila/share/drivers/cephfs/driver.py
View File

@ -126,7 +126,7 @@ cephfs_opts = [
"Ganesha server host. This is not required if "
"'cephfs_ganesha_path_to_private_key' is configured."),
cfg.ListOpt('cephfs_ganesha_export_ips',
default='',
default=[],
help="List of IPs to export shares. If not supplied, "
"then the value of 'cephfs_ganesha_server_ip' "
"will be used to construct share export locations."),

3
manila/tests/share/drivers/cephfs/test_driver.py
View File

@ -1004,7 +1004,8 @@ class NFSProtocolHelperTestCase(test.TestCase):
fake_conf = configuration.Configuration(None)
conf_args_list = [
('cephfs_ganesha_server_ip', '1.2.3.4'),
('cephfs_ganesha_export_ips', '127.0.0.1,fd3f:c057:1192:1::1,::1')]
('cephfs_ganesha_export_ips',
['127.0.0.1', 'fd3f:c057:1192:1::1', '::1'])]
for args in conf_args_list:
fake_conf.set_default(*args)