Update patch set 1

Browse Source

Patch Set 1: Code-Review-1

As we've discussed over IRC and on the phone about the param "cleanup_source_server":

1) we don't need to use the param to override the CONF.delete_share_server_with_last_share because when that setting is false we operate under the assumption that the admin knows he will have to invoke share server delete API to delete share servers manually
2) we don't really need cleanup_source_server as it is cleaner semantically that at the end of a share server migration the manager will invoke check_delete_share_server which will remove the share server when the instance count is 0. Less variations, less complexity, less need for testing and maintenance.
3) As for the driver purposes behind cleanup_source_server, the driver functionality would be attempted to be simplified to match manila's semantics, even if it results in not the best efficiency, while also having as benefits less complexity and need for testing/maintenance for the driver.

Patch-set: 1
Reviewer: Gerrit User 14567 <14567@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Label: Code-Review=-1

...

This commit is contained in:

Gerrit User 14567 2021-08-05 21:01:42 +00:00 committed by Gerrit Code Review

parent 4ab199fa1e

commit dc03b02bc1

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Show Stats Download Patch File Download Diff File Expand all files Collapse all files

Diff Content Not Available