openstack
/
manila
Code Issues Proposed changes

Remove aggressive assert from share server test 

The delete_share_server test has an assert which can
fail in case of retries and give a false negative result.
This assert isn't necessary to check for correctness, so
remove it.

Closes-bug: 1546618

Change-Id: Ib04afdc222e19725df4da0793c1ffcc15282a772
This commit is contained in:
Ben Swartzlander 2016-02-17 16:30:19 -05:00
parent 29cbef0532
commit e6c66917eb
1 changed files with 1 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
manila_tempest_tests/tests/api/admin/test_share_servers.py
View File

@ -219,7 +219,7 @@ class ShareServersAdminTest(base.BaseSharesAdminTest):
neutron_subnet_id=self.share_network['neutron_subnet_id'])
# Create server with share
share = self.create_share(share_network_id=new_sn['id'])
self.create_share(share_network_id=new_sn['id'])
# List share servers, filtered by share_network_id
search_opts = {"share_network": new_sn["id"]}
@ -238,7 +238,6 @@ class ShareServersAdminTest(base.BaseSharesAdminTest):
shares = self.shares_client.list_shares_with_detail(params)
for s in shares:
self.assertEqual(new_sn["id"], s["share_network_id"])
self.assertTrue(any(share["id"] == s["id"] for s in shares))
# Delete shares, so we will have share server without shares
for s in shares: