Browse Source

Fix api error message for snapshot creation failure

when the source share has ``snapshot_support`` False.

The message said that the back end lacks snapshot support but this
is not necessarily the case.

Closes-bug: #1925342
Change-Id: I09a83b63528c0988f3601dfd07ad6972165cb855
(cherry picked from commit be29805859)
(cherry picked from commit fb5a4f936d)
changes/90/792290/1
Tom Barron 2 months ago
parent
commit
fa9ac6d782
2 changed files with 12 additions and 2 deletions
  1. +2
    -2
      manila/api/v1/share_snapshots.py
  2. +10
    -0
      releasenotes/notes/bug-1925342-fix-snapshot-support-api-error-msg-eaf5fd2b1df97d15.yaml

+ 2
- 2
manila/api/v1/share_snapshots.py View File

@ -181,8 +181,8 @@ class ShareSnapshotMixin(object):
# Verify that share can be snapshotted
if not share['snapshot_support']:
msg = _("Snapshot cannot be created from share '%s', because "
"share back end does not support it.") % share_id
msg = _("Snapshots cannot be created for share '%s' "
"since it does not have that capability.") % share_id
LOG.error(msg)
raise exc.HTTPUnprocessableEntity(explanation=msg)


+ 10
- 0
releasenotes/notes/bug-1925342-fix-snapshot-support-api-error-msg-eaf5fd2b1df97d15.yaml View File

@ -0,0 +1,10 @@
---
fixes:
- |
Corrected an error message for attempts to create snapshots from shares
that do not support this operation. The message said that the share
backend has no such support but that is not always true. The original
share for the snapshot does not support snapshots because it was created
with a share type without the ``snapshot_support`` extra-spec set,
irrespective of whether the back end used can itself support snapshots
or not.

Loading…
Cancel
Save