When we delete the shared instance, in addition to erasing the data
in the share, we should disconnect the client's mount point to
prevent the data from being written in.
Closes-Bug: #1886010
Change-Id: I7a334fb895669cc807a288e6aefe62154a89a7e4
(cherry picked from commit 9d44ba0b6a)
DellEMC manila drivers have bugs in returning capacity in pool_stat.
The current powermax/vnx manila return size in MB and unity manila
returns size in bytes.
Change-Id: I1a2c28548d02eee6632313a41a5c4d8ab6ad9532
Closes-bug: #1890372
Closes-bug: #1890375
Closes-bug: #1890376
(cherry picked from commit 53f756d065)
During maintenance, administrators may decide
to unmount shares, snapshots or remove them
entirely prior to cleaning up LVM share resources
in manila. The driver should not fail on deletion
of missing resources.
Change-Id: Ieaf37ec10db9a8bdce6bb195b76335fea9b2b52f
Closes-Bug: #1888915
Signed-off-by: Goutham Pacha Ravi <gouthampravi@gmail.com>
(cherry picked from commit e57809fd74)
ONTAP 9.5 adds vserver cifs domain preferred-dc configuration
validation. The parameter 'skip-config-validation' is mandatory
for 'cifs-domain-preferred-dc-add' now and is set to false,
i.e. an invalid config will raise early.
Change-Id: I5eb97ba1b29ad24b296e12064f81eb93533c6b99
Closes-Bug: 1887643
(cherry picked from commit 3057d0643e8a93c4ae857159d96e94541ad0be4d)
Because ``service`` commands are deprecated in favor of
``systemctl` commands, the check to see if the service
command succeeds in the NFS helper used by e.g. the
lvm and generic back ends fails. The string sought to
indicate an error is never present.
Update the helper to use ``systemctl`` commands instead
and error check for them correctly.
Closes-bug: #1887695
Change-Id: Ibb1c15f997fa60e1ba5bfb7437502d8aa454d35f
(cherry picked from commit 391ec7dffa)
- do *not* skip fsck when extending
- have extend resize the filesystem itself
rather than making a separate execution
of ``resize2fs``
Closes-bug: #1887694
Change-Id: I67ac549e790322c56d02db4424ec01a5449e6633
NetApp ONTAP share delete operation can fail sometimes when is triggered
immediately after migration cancelation on a overloaded NetApp backend.
Migration cancelation invokes "abort_volume_move" which is an asynchronous
API. If share delete operation is requested immediately after call the
former API, it fails because the "abort_volume_move" is still in progress.
Now NetApp cDOT driver checks, for a period of time, if the
``volume-move-abort`` operation has ended before report migration
cancelation success.
This patch squash the following commit that improves the release note
for this fix:
[NetApp] Updating the release note for bugfix 1688620
(cherry picked from commit a0dd86a98788f7e2d1ca55be26c2a3dea4e36f57)
Change-Id: I76e11fef27c9723f019cfdfdc6ea86878db78776
Closes-Bug: #1688620
(cherry picked from commit 0ee4140823)
With python3.7, the eventlet is breaking the ssl.py, so the https
is not working. This patch fixes it by changing the request library
(urllib by requests), the new library can be built over the
pyopenssl.py instead of ssl.py.
Closes-Bug: #1878993
Change-Id: I9c0b1f332ead25634f3dc3aebfdc8b51dfbc4178
(cherry picked from commit 29622725e4)
When the NetApp backend starts, it needs to know whether the
`revert_to_snapshot` support exist. So, it was retrieving the
licenses and checking if the `SnapRestore` is included. Using a
scoped account, the backend cannot retrieve that information,
though. So, this patch solves it by sending a fake operation
`revert_to_snapshot` that must fail. Analyzing the given error, it
sets the backend support field.
Closes-Bug: #1882590
Change-Id: Ib71a6cec939288498e48736f129fbfdacaabe9da
(cherry picked from commit 6f58af1ae3)
It is no need to enable ACE when creating CIFS share, so
remove this process.
Change-Id: Id9d248857c9a02eca486185d41b1fc22520d0919
Closes-bug: #1841035
(cherry picked from commit 47b90fa8fb)
Unmouting of the volume from service instance sometimes fails because
Windows clients tends to check the availability of shares even if not
mounted and the volume is in use then.
Fix finds out processes via smbstatus and kill them before unmounting.
Closes-Bug: 1703581
Change-Id: I2cbf959d7cb849d3ead1655b1a0932fd428a9e9f
Signed-off-by: Goutham Pacha Ravi <gouthampravi@gmail.com>
(cherry picked from commit 2c9fbc75059ac724cd845317473b7df4a8dcdc35)
The NetApp driver is fixed to avoid the deletion of cluster
ipspaces when deleting a share server. Now the share server
deletion skip ipspace removal if the ipspace is one of the
following: Cluster or Default.
Change-Id: I24cda6be69ef9258c6c637be48be32b93d835e0a
Closes-Bug: #1880747
(cherry picked from commit dbe34c08e2)
Neutron can filter ports by subnet-id by itself, so:
- Don't send all ports in Neutron on every share-server removal
- Don't send fixed-ips fields (which are nearly half of total data)
Closes-Bug: #1879754
Change-Id: If42c9a0a662a62bbe2a02b6baee6ae13eedd8c97
Signed-off-by: George Melikov <mail@gmelikov.ru>
(cherry picked from commit d5fc7d2802)
The NetApp driver is now fixed to not trigger vserver peer accept when
handling with share replica operations on 'driver_handle_share_servers'
mode enabled.
Closes-Bug: #1873963
Change-Id: I9df8b48bf2c127f266c1b950bafc710bc28f7632
This patch fixes the error raised by NetApp driver when the user try
to shrink a share to a size smaller than the current used space. Now
the driver raises "shrinking_possible_data_loss" instead of
"shrinking_error".
Change-Id: I01a549a0e299ae0d0d9b603a9d0797f16f4b68b3
Closes-Bug: #1858328
It fixes the export locations returned by `create_share` and
`create_share_from_snapshot`. The export locations should be a list of
dict like: `[{'path': <original_location>}]`.
Change-Id: Ic97fa34455054aeda10608486edf120a9dc3d9f3
Closes-bug: #1871999
The NetApp cDOT driver is now fixed to ignore vserver peering
when creating and promoting shares replicas within the same
vserver.
Closes-Bug: #1872243
Change-Id: I0b82c15aec7862ee3630330805ac3ac177aae127
This patch improves the operation of creating share from snapshot
to accept new destinations that can be different pools or
back ends.
Change-Id: Id3b3d5860d6325f368cbebfe7f97c98d64554d72
This patch improves the operation of create share from snapshot
to support different backends/hosts for the zfsonlinux driver
Partially-implements: bp create-share-from-snapshot-in-another-pool-or-backend
Depends-On: Iab13a0961eb4a387a502246e5d4b79bc9046e04b
Change-Id: I124803734c81d3630c5147f5f3bb75724489c929
This patch enables the creation of a share from snapshot
specifying another pool or backend. In the scheduler, a
new filter and weigher were implemented in order to consider
this operation if the backend supports it. Also, a new
field called 'progress' was added in the share and share
instance. The 'progress' field indicates the status
of the operation create share from snapshot (in percentage).
Finally, a new periodic task was added in order to constantly
check the share status.
Partially-implements: bp create-share-from-snapshot-in-another-pool-or-backend
DOCImpact
Change-Id: Iab13a0961eb4a387a502246e5d4b79bc9046e04b
Co-authored-by: carloss <ces.eduardo98@gmail.com>
Co-authored-by: dviroel <viroel@gmail.com>
1. Try parse share_backend_id from export path in case
it is managed share.
2. Try to take snapshot id from 'provider_location' in case
this is managed snapshot
3. Try to get share server name from property 'identifier'
first in case this is managed share server
4. Add property 'provider_location' when creating snapshot
Implements: blueprint emc-unity-manage-unmange
Change-Id: I676475d0500ecce31a1a863926accec8585ac83a
Signed-off-by: Goutham Pacha Ravi <gouthampravi@gmail.com>
Fix:
W605 invalid escape sequence
This is the final change I plan for hacking, the remaining problems
need further investigation by manila team and decision whether and how
to solve them.
Change-Id: I73d73e044eaaf412bf7ace358a3f07c8d269d6cf
Fix:
E731 do not assign a lambda expression, use a def
I just marked the lambdas with noqa.
Fix also other problems found by hacking in files changed.
Change-Id: I4e47670f5a96e61fba617e4cb9478958f7089711
Fix:
E241 multiple spaces after ':' (or ',')
Fix also a few other problems found by hacking in files changed.
Change-Id: I4c00551f29ad65df2631c8ae55fe2f022e872544
Fix:
F841 local variable 'e' is assigned to but never used
Also, fix other problems found by hacking in these files.
Change-Id: Ib6eaf27c8e6f1414acc9dbde41a35bd412b7161e
Fix F632 use ==/!= to compare str, bytes, and int literal
Fix also other problems in the files found by hacking checks.
Change-Id: I5122a9bbccd40d869b54fa3ddf754685aefb8d57
NetApp cDOT driver is now fixed to remove the QoS Policy on the
backend volume when a share is migrated from an extra-spec which had
QoS defined to another extra-spec which has no QoS defined in it.
Change-Id: I57c2e15fc22eb2bf69ebee25a92ba10746505e73
Closes-Bug: #1706137
During migration and manage/unmanage operations, if we used standard
extra_specs format (e.g. 'thin_provisioning'='True') instead of
NetApp based extra_specs format (e.g. 'netapp:thin_provisioned'='True'),
NetApp driver used to ignore these standard extra_specs settings
and continued the operation with the default option.
The driver is now fixed to handle this issue by honouring the
standard extra_specs during migration and manage/unmanage.
Change-Id: I48f4d966201fc8d6bd6eec0c37f1575b434310e7
Closes-Bug: #1707084
The `interface_driver` option needs some clarification.
While we only support three interface mechanisms,
it's possible that deployers can use their own
interface driver, so using oslo_config's choices
for this option does not make sense.
Depends-On: I2c3d6e4234bf7185b8da3c8e1701069c3a165ffc
Change-Id: I1cc710dbe87e9e23fbed63dcd5f1017978393c66
The code for clearing routes currently lives inside the
service_instance module but it belongs better inside the linux
interface ones.
This patch refactors it into there, which can allow for a true
noop driver as all network operations would happen inside that
section.
Change-Id: I9fa29e9e5ed7dd2c620b56efab559f4cec25aced
This patch refactors the code which clears routes into another
function which already gets all of the subnets to avoid hitting
the Neutron API twice, and allowing us to eventually refactor
all of this code into the linux interface management API.
Change-Id: I6e1debce1ac379d15190db82299bdd92c9ff7734
There's a few functions which are used inside service_instance
which do networking that can live inside the linux interface
driver code.
This patch refactors them into there as this helps allow for
the noop driver.
Change-Id: Ib79ae3f08843414a552c89cd9a254b5e562123b8
Glance image list API supports pagination, but `_get_service_image`
uses novaclient.glance.list() that only return images in one page.
When the image needed by share server is not returned in the first
page, the exception occurs. This patch uses `find_image` method
to get the image.
Since latest novaclient has no proxy to lookup image, so only
novaclient.glance.
Change-Id: I57b15b7ebb29c545c9780a90734988565fa1f6b7
Closes-Bug: #1844046
Fix to ensure that hosts that are given access to a share i.e read only,
will always precede '-0.0.0.0/0.0.0.0' in Access host. Any host after
this string will be denied access.
Change-Id: I813191abc592703d6aa7ea55c5be81d1a6089f39
Closes-Bug: #1845147
This patch fix an issue in NetApp driver share replica periodic
check that erroneuouly set a share replica to error after receiving
a 'Another transfer is in progress' error. The driver now skips the
resync operation for all expected transfer in progress relationship
status.
Closes-Bug: #1848889
Change-Id: If82aaa184db84660389f82654279f3c5b238fd51
The NetApp ONTAP driver is now fixed to allow extension
and shrinking of share replicas after they get promoted.
Change-Id: Iea92feaf5894c10674d2ec4c1a4d7b0191e6d5b4
Closes-Bug: #1700871
When set 'reclaim_instance_interval' larger than 0, share server
was deleted cause that the server exists until
reclaim_instance_interval. This patch checks status 'soft_deleted'
of instance to avoid the timeout.
Change-Id: Ib481c1699b19ee8c37473081f1aec780ed384e9d
Closes-Bug: #1844596
This patch adds support for replication with DHSS=True on
NetApp driver. It now handles peering operations between
share servers and shares.
Change-Id: I93888bcc6a0ca672671cf2aa254ceb23c4cbf692
Support 'driver_handles_share_servers = False' in manila.conf.
In such mode, need set unity_share_server in manila.conf, driver
will use this NAS server for share creation.
Change-Id: Iebc30d289fdb9f250e4951257313d630faa8bdf7
This driver supports NFS and CIFS shares.
The following operations are supported:
- Create a share.
- Delete a share.
- Allow share access.
- Deny share access.
- Manage a share.
- Unmanage a share.
- Extend a share.
- Shrink a share.
DocImpact
Implements: blueprint infortrend-support-manila-driver
Change-Id: Ib1adbd8f7f55805387b126851dbb0ff50cfbcd75
linpeiwen
Sam Wan
Goutham Pacha Ravi
Maurice Escher
Tom Barron
danielarthurt
Felipe Rodrigues
Felipe Rodrigues
Yong Huang
Jan Vondra
Douglas Viroel
George Melikov
Ryan Liang
andrebeltrami
dingd
Andreas Jaeger
Naresh Kumar Gunjalli
Mohammed Naser
zhufl
ericxiett
Helen Walsh
Lucio Seki
Alexey Khodos
Woohyung Han
Kuirong.Chen