fd23a6387c
Fix pylint E103 warning raised by usage of self.__class__ to refer to the derived class in super() methods. self.__class__ is a reasonable first argument to super() in any method of a class, as long as the method is not going to be invoked in derived classes. Python3 removes this ambiguity by not requiring arguments for the super() method. [1] https://docs.pylint.org/en/1.6.0/features.html#id33 Change-Id: I6071b6cfd8cff2be3853d739f71b94da990cda97
241 lines
8.1 KiB
Python
241 lines
8.1 KiB
Python
# Copyright 2010 United States Government as represented by the
|
|
# Administrator of the National Aeronautics and Space Administration.
|
|
# Copyright 2014 NetApp, Inc.
|
|
# Copyright 2014 Mirantis, Inc.
|
|
#
|
|
# All Rights Reserved.
|
|
#
|
|
# Licensed under the Apache License, Version 2.0 (the "License"); you may
|
|
# not use this file except in compliance with the License. You may obtain
|
|
# a copy of the License at
|
|
#
|
|
# http://www.apache.org/licenses/LICENSE-2.0
|
|
#
|
|
# Unless required by applicable law or agreed to in writing, software
|
|
# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
|
|
# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
|
|
# License for the specific language governing permissions and limitations
|
|
# under the License.
|
|
|
|
"""
|
|
Unit Tests for remote procedure calls using queue
|
|
"""
|
|
|
|
import ddt
|
|
import mock
|
|
from oslo_config import cfg
|
|
from oslo_service import wsgi
|
|
|
|
from manila import context
|
|
from manila import db
|
|
from manila import exception
|
|
from manila import manager
|
|
from manila import service
|
|
from manila import test
|
|
from manila import utils
|
|
|
|
test_service_opts = [
|
|
cfg.StrOpt("fake_manager",
|
|
default="manila.tests.test_service.FakeManager",
|
|
help="Manager for testing"),
|
|
cfg.StrOpt("test_service_listen",
|
|
help="Host to bind test service to"),
|
|
cfg.IntOpt("test_service_listen_port",
|
|
default=0,
|
|
help="Port number to bind test service to"),
|
|
]
|
|
|
|
CONF = cfg.CONF
|
|
CONF.register_opts(test_service_opts)
|
|
|
|
|
|
class FakeManager(manager.Manager):
|
|
"""Fake manager for tests."""
|
|
|
|
RPC_API_VERSION = "1.0"
|
|
|
|
def __init__(self, host=None, db_driver=None, service_name=None):
|
|
super(FakeManager, self).__init__(host=host, db_driver=db_driver)
|
|
|
|
def test_method(self):
|
|
return 'manager'
|
|
|
|
|
|
class ExtendedService(service.Service):
|
|
def test_method(self):
|
|
return 'service'
|
|
|
|
|
|
class ServiceManagerTestCase(test.TestCase):
|
|
"""Test cases for Services."""
|
|
|
|
def test_message_gets_to_manager(self):
|
|
serv = service.Service('test', 'test', 'test', CONF.fake_manager)
|
|
serv.start()
|
|
self.assertEqual('manager', serv.test_method())
|
|
|
|
def test_override_manager_method(self):
|
|
serv = ExtendedService('test', 'test', 'test', CONF.fake_manager)
|
|
serv.start()
|
|
self.assertEqual('service', serv.test_method())
|
|
|
|
|
|
class ServiceFlagsTestCase(test.TestCase):
|
|
def test_service_enabled_on_create_based_on_flag(self):
|
|
self.flags(enable_new_services=True)
|
|
host = 'foo'
|
|
binary = 'manila-fake'
|
|
app = service.Service.create(host=host, binary=binary)
|
|
app.start()
|
|
app.stop()
|
|
ref = db.service_get(context.get_admin_context(), app.service_id)
|
|
db.service_destroy(context.get_admin_context(), app.service_id)
|
|
self.assertFalse(ref['disabled'])
|
|
|
|
def test_service_disabled_on_create_based_on_flag(self):
|
|
self.flags(enable_new_services=False)
|
|
host = 'foo'
|
|
binary = 'manila-fake'
|
|
app = service.Service.create(host=host, binary=binary)
|
|
app.start()
|
|
app.stop()
|
|
ref = db.service_get(context.get_admin_context(), app.service_id)
|
|
db.service_destroy(context.get_admin_context(), app.service_id)
|
|
self.assertTrue(ref['disabled'])
|
|
|
|
|
|
def fake_service_get_by_args(*args, **kwargs):
|
|
raise exception.NotFound()
|
|
|
|
|
|
def fake_service_get(*args, **kwargs):
|
|
raise Exception()
|
|
|
|
|
|
host = 'foo'
|
|
binary = 'bar'
|
|
topic = 'test'
|
|
service_create = {
|
|
'host': host,
|
|
'binary': binary,
|
|
'topic': topic,
|
|
'report_count': 0,
|
|
'availability_zone': 'nova',
|
|
}
|
|
service_ref = {
|
|
'host': host,
|
|
'binary': binary,
|
|
'topic': topic,
|
|
'report_count': 0,
|
|
'availability_zone': {'name': 'nova'},
|
|
'id': 1,
|
|
}
|
|
|
|
|
|
@ddt.ddt
|
|
class ServiceTestCase(test.TestCase):
|
|
"""Test cases for Services."""
|
|
|
|
def test_create(self):
|
|
app = service.Service.create(host='foo',
|
|
binary='manila-fake',
|
|
topic='fake')
|
|
self.assertTrue(app)
|
|
|
|
@ddt.data(True, False)
|
|
def test_periodic_tasks(self, raise_on_error):
|
|
serv = service.Service(host, binary, topic, CONF.fake_manager)
|
|
self.mock_object(
|
|
context,
|
|
'get_admin_context',
|
|
mock.Mock(side_effect=context.get_admin_context))
|
|
self.mock_object(serv.manager, 'periodic_tasks')
|
|
|
|
serv.periodic_tasks(raise_on_error=raise_on_error)
|
|
|
|
context.get_admin_context.assert_called_once_with()
|
|
serv.manager.periodic_tasks.assert_called_once_with(
|
|
utils.IsAMatcher(context.RequestContext),
|
|
raise_on_error=raise_on_error)
|
|
|
|
@mock.patch.object(service.db, 'service_get_by_args',
|
|
mock.Mock(side_effect=fake_service_get_by_args))
|
|
@mock.patch.object(service.db, 'service_create',
|
|
mock.Mock(return_value=service_ref))
|
|
@mock.patch.object(service.db, 'service_get',
|
|
mock.Mock(side_effect=fake_service_get))
|
|
def test_report_state_newly_disconnected(self):
|
|
serv = service.Service(host, binary, topic, CONF.fake_manager)
|
|
serv.start()
|
|
serv.report_state()
|
|
self.assertTrue(serv.model_disconnected)
|
|
service.db.service_get_by_args.assert_called_once_with(
|
|
mock.ANY, host, binary)
|
|
service.db.service_create.assert_called_once_with(
|
|
mock.ANY, service_create)
|
|
service.db.service_get.assert_called_once_with(mock.ANY, mock.ANY)
|
|
|
|
@mock.patch.object(service.db, 'service_get_by_args',
|
|
mock.Mock(side_effect=fake_service_get_by_args))
|
|
@mock.patch.object(service.db, 'service_create',
|
|
mock.Mock(return_value=service_ref))
|
|
@mock.patch.object(service.db, 'service_get',
|
|
mock.Mock(return_value=service_ref))
|
|
@mock.patch.object(service.db, 'service_update',
|
|
mock.Mock(return_value=service_ref.
|
|
update({'report_count': 1})))
|
|
def test_report_state_newly_connected(self):
|
|
serv = service.Service(host, binary, topic, CONF.fake_manager)
|
|
serv.start()
|
|
serv.model_disconnected = True
|
|
serv.report_state()
|
|
self.assertFalse(serv.model_disconnected)
|
|
service.db.service_get_by_args.assert_called_once_with(
|
|
mock.ANY, host, binary)
|
|
service.db.service_create.assert_called_once_with(
|
|
mock.ANY, service_create)
|
|
service.db.service_get.assert_called_once_with(
|
|
mock.ANY, service_ref['id'])
|
|
service.db.service_update.assert_called_once_with(
|
|
mock.ANY, service_ref['id'], mock.ANY)
|
|
|
|
|
|
class TestWSGIService(test.TestCase):
|
|
|
|
def setUp(self):
|
|
super(TestWSGIService, self).setUp()
|
|
self.mock_object(wsgi.Loader, 'load_app')
|
|
self.test_service = service.WSGIService("test_service")
|
|
|
|
def test_service_random_port(self):
|
|
self.assertEqual(0, self.test_service.port)
|
|
self.test_service.start()
|
|
self.assertNotEqual(0, self.test_service.port)
|
|
self.test_service.stop()
|
|
wsgi.Loader.load_app.assert_called_once_with("test_service")
|
|
|
|
def test_reset_pool_size_to_default(self):
|
|
self.test_service.start()
|
|
|
|
# Stopping the service, which in turn sets pool size to 0
|
|
self.test_service.stop()
|
|
self.assertEqual(0, self.test_service.server._pool.size)
|
|
|
|
# Resetting pool size to default
|
|
self.test_service.reset()
|
|
self.test_service.start()
|
|
self.assertGreater(self.test_service.server._pool.size, 0)
|
|
wsgi.Loader.load_app.assert_called_once_with("test_service")
|
|
|
|
@mock.patch('oslo_service.wsgi.Server')
|
|
@mock.patch('oslo_service.wsgi.Loader')
|
|
def test_ssl_enabled(self, mock_loader, mock_server):
|
|
self.override_config('osapi_share_use_ssl', True)
|
|
|
|
service.WSGIService("osapi_share")
|
|
mock_server.assert_called_once_with(mock.ANY, mock.ANY, mock.ANY,
|
|
port=mock.ANY, host=mock.ANY,
|
|
use_ssl=True)
|
|
|
|
self.assertTrue(mock_loader.called)
|