af2e103514
With oslo-incubator going away, we need to pull those classes into the Manila code base, along with their unit tests. This presents a good opportunity to do some long-needed housecleaning. This commit does the following: 1. Moves the scheduler classes from openstack.common to manila. 2. Adds the unit tests from olso-incubator into Manila. 3. Removes duplication among the combined scheduler modules. 4. Moves scheduler drivers into a sub-module. 5. Normalizes class and module naming throughout the scheduler. 6. Splits some unit test files so they match the names of the modules that they test. 7. Converts usage of mox & oslotest to mock & unittest. 8. Adds a few unit tests to boost coverage levels. Implements: blueprint reorganize-manila-scheduler Change-Id: I7aa237e17787e89a95bb198093ea9bc9498279cd
49 lines
1.8 KiB
Python
49 lines
1.8 KiB
Python
# Copyright (c) 2011-2013 OpenStack Foundation.
|
|
# All Rights Reserved.
|
|
#
|
|
# Licensed under the Apache License, Version 2.0 (the "License"); you may
|
|
# not use this file except in compliance with the License. You may obtain
|
|
# a copy of the License at
|
|
#
|
|
# http://www.apache.org/licenses/LICENSE-2.0
|
|
#
|
|
# Unless required by applicable law or agreed to in writing, software
|
|
# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
|
|
# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
|
|
# License for the specific language governing permissions and limitations
|
|
# under the License.
|
|
|
|
"""
|
|
A common base for handling extension classes.
|
|
|
|
Used by BaseFilterHandler and BaseWeightHandler
|
|
"""
|
|
|
|
import inspect
|
|
|
|
from stevedore import extension
|
|
|
|
|
|
class BaseHandler(object):
|
|
"""Base class to handle loading filter and weight classes."""
|
|
def __init__(self, modifier_class_type, modifier_namespace):
|
|
self.namespace = modifier_namespace
|
|
self.modifier_class_type = modifier_class_type
|
|
self.extension_manager = extension.ExtensionManager(modifier_namespace)
|
|
|
|
def _is_correct_class(self, cls):
|
|
"""Check if an object is the correct type.
|
|
|
|
Return whether an object is a class of the correct type and
|
|
is not prefixed with an underscore.
|
|
"""
|
|
return (inspect.isclass(cls) and
|
|
not cls.__name__.startswith('_') and
|
|
issubclass(cls, self.modifier_class_type))
|
|
|
|
def get_all_classes(self):
|
|
# We use a set, as some classes may have an entrypoint of their own,
|
|
# and also be returned by a function such as 'all_filters' for example
|
|
return [ext.plugin for ext in self.extension_manager if
|
|
self._is_correct_class(ext.plugin)]
|