98255e6715
Basically, if you decide to override a method, that is because you want to specify(or modify) the behavior of a method. If you just call the inherited method from the overridden method, that is unnecessary. Furthermore, every time when self.setUp() is called, now the super's setUp() is called, which is basically exact the same behavior as we have now. TrivialFix Change-Id: I9f4e03b93ff075c66b4e52342711c37f226d2f81
79 lines
2.9 KiB
Python
79 lines
2.9 KiB
Python
# Copyright 2010 United States Government as represented by the
|
|
# Administrator of the National Aeronautics and Space Administration.
|
|
# All Rights Reserved.
|
|
# Copyright 2011 Red Hat, Inc.
|
|
#
|
|
# Licensed under the Apache License, Version 2.0 (the "License"); you may
|
|
# not use this file except in compliance with the License. You may obtain
|
|
# a copy of the License at
|
|
#
|
|
# http://www.apache.org/licenses/LICENSE-2.0
|
|
#
|
|
# Unless required by applicable law or agreed to in writing, software
|
|
# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
|
|
# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
|
|
# License for the specific language governing permissions and limitations
|
|
# under the License.
|
|
|
|
from oslo_config import cfg
|
|
|
|
|
|
from manila import test
|
|
|
|
CONF = cfg.CONF
|
|
CONF.register_opt(cfg.StrOpt('conf_unittest',
|
|
default='foo',
|
|
help='for testing purposes only'))
|
|
|
|
|
|
class ConfigTestCase(test.TestCase):
|
|
|
|
def test_declare(self):
|
|
self.assertNotIn('answer', CONF)
|
|
CONF.import_opt('answer', 'manila.tests.declare_conf')
|
|
self.assertIn('answer', CONF)
|
|
self.assertEqual(42, CONF.answer)
|
|
|
|
# Make sure we don't overwrite anything
|
|
CONF.set_override('answer', 256)
|
|
self.assertEqual(256, CONF.answer)
|
|
CONF.import_opt('answer', 'manila.tests.declare_conf')
|
|
self.assertEqual(256, CONF.answer)
|
|
|
|
def test_runtime_and_unknown_flags(self):
|
|
self.assertNotIn('runtime_answer', CONF)
|
|
import manila.tests.runtime_conf # noqa
|
|
self.assertIn('runtime_answer', CONF)
|
|
self.assertEqual(54, CONF.runtime_answer)
|
|
|
|
def test_long_vs_short_flags(self):
|
|
CONF.clear()
|
|
CONF.register_cli_opt(cfg.StrOpt('duplicate_answer_long',
|
|
default='val',
|
|
help='desc'))
|
|
CONF.register_cli_opt(cfg.IntOpt('duplicate_answer',
|
|
default=50,
|
|
help='desc'))
|
|
|
|
argv = ['--duplicate_answer=60']
|
|
CONF(argv, default_config_files=[])
|
|
self.assertEqual(60, CONF.duplicate_answer)
|
|
self.assertEqual('val', CONF.duplicate_answer_long)
|
|
|
|
def test_flag_leak_left(self):
|
|
self.assertEqual('foo', CONF.conf_unittest)
|
|
self.flags(conf_unittest='bar')
|
|
self.assertEqual('bar', CONF.conf_unittest)
|
|
|
|
def test_flag_leak_right(self):
|
|
self.assertEqual('foo', CONF.conf_unittest)
|
|
self.flags(conf_unittest='bar')
|
|
self.assertEqual('bar', CONF.conf_unittest)
|
|
|
|
def test_flag_overrides(self):
|
|
self.assertEqual('foo', CONF.conf_unittest)
|
|
self.flags(conf_unittest='bar')
|
|
self.assertEqual('bar', CONF.conf_unittest)
|
|
CONF.reset()
|
|
self.assertEqual('foo', CONF.conf_unittest)
|