5b76212da4
LOG.xxx("Hello %s" % xyz) should be LOG.xxx("Hello %s", xyz).
This allows the logging package to skip creating the
formatted log message if the message is not going to be emitted because
of the current log level.
The change touches error, warning and info LOG messages.
Adjust test suite for the above change since LOG now uses two parameters
instead of one.
Fix grammar, add missing "." to log messages in some places.
Change-Id: I86404c34502f07ed6dbda1c82b13db888c60f074
73 lines
2.6 KiB
Python
73 lines
2.6 KiB
Python
# vim: tabstop=4 shiftwidth=4 softtabstop=4
|
|
|
|
# Copyright 2011 OpenStack LLC
|
|
#
|
|
# Licensed under the Apache License, Version 2.0 (the "License"); you may
|
|
# not use this file except in compliance with the License. You may obtain
|
|
# a copy of the License at
|
|
#
|
|
# http://www.apache.org/licenses/LICENSE-2.0
|
|
#
|
|
# Unless required by applicable law or agreed to in writing, software
|
|
# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
|
|
# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
|
|
# License for the specific language governing permissions and limitations
|
|
# under the License.
|
|
|
|
from manila import context
|
|
from manila import test
|
|
|
|
|
|
class ContextTestCase(test.TestCase):
|
|
|
|
def test_request_context_sets_is_admin(self):
|
|
ctxt = context.RequestContext('111',
|
|
'222',
|
|
roles=['admin', 'weasel'])
|
|
self.assertEqual(ctxt.is_admin, True)
|
|
|
|
def test_request_context_sets_is_admin_upcase(self):
|
|
ctxt = context.RequestContext('111',
|
|
'222',
|
|
roles=['Admin', 'weasel'])
|
|
self.assertEqual(ctxt.is_admin, True)
|
|
|
|
def test_request_context_read_deleted(self):
|
|
ctxt = context.RequestContext('111',
|
|
'222',
|
|
read_deleted='yes')
|
|
self.assertEqual(ctxt.read_deleted, 'yes')
|
|
|
|
ctxt.read_deleted = 'no'
|
|
self.assertEqual(ctxt.read_deleted, 'no')
|
|
|
|
def test_request_context_read_deleted_invalid(self):
|
|
self.assertRaises(ValueError,
|
|
context.RequestContext,
|
|
'111',
|
|
'222',
|
|
read_deleted=True)
|
|
|
|
ctxt = context.RequestContext('111', '222')
|
|
self.assertRaises(ValueError,
|
|
setattr,
|
|
ctxt,
|
|
'read_deleted',
|
|
True)
|
|
|
|
def test_extra_args_to_context_get_logged(self):
|
|
info = {}
|
|
|
|
def fake_warn(log_msg, other_args):
|
|
info['log_msg'] = log_msg % other_args
|
|
|
|
self.stubs.Set(context.LOG, 'warn', fake_warn)
|
|
|
|
c = context.RequestContext('user',
|
|
'project',
|
|
extra_arg1='meow',
|
|
extra_arg2='wuff')
|
|
self.assertTrue(c)
|
|
self.assertIn("'extra_arg1': 'meow'", info['log_msg'])
|
|
self.assertIn("'extra_arg2': 'wuff'", info['log_msg'])
|