Goutham Pacha Ravi
a13ff5d5a7
There was a traceback being included in the error message body. This is unhelpful to end users. The error message that included the traceback was for this corner case where the RBAC policy isn't aligned with the internal "context_is_admin" policy - an unlikely combination of decisions that a deployer would make - nevertheless, this is an opportunity for us to fix this code path. Change-Id: I888d684acac2133425f986ec7cef5e4f5cdcc5b6 Closes-Bug: #1917520 Signed-off-by: Goutham Pacha Ravi <gouthampravi@gmail.com>
86 lines
3.4 KiB
Python
86 lines
3.4 KiB
Python
# Copyright (c) 2015 Clinton Knight. All rights reserved.
|
|
#
|
|
# Licensed under the Apache License, Version 2.0 (the "License"); you may
|
|
# not use this file except in compliance with the License. You may obtain
|
|
# a copy of the License at
|
|
#
|
|
# http://www.apache.org/licenses/LICENSE-2.0
|
|
#
|
|
# Unless required by applicable law or agreed to in writing, software
|
|
# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
|
|
# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
|
|
# License for the specific language governing permissions and limitations
|
|
# under the License.
|
|
from webob import exc
|
|
|
|
from manila.api.openstack import wsgi
|
|
from manila.api.views import scheduler_stats as scheduler_stats_views
|
|
from manila import exception
|
|
from manila.i18n import _
|
|
from manila.scheduler import rpcapi
|
|
from manila.share import share_types
|
|
|
|
|
|
class SchedulerStatsController(wsgi.Controller):
|
|
"""The Scheduler Stats API controller for the OpenStack API."""
|
|
|
|
resource_name = 'scheduler_stats:pools'
|
|
|
|
def __init__(self):
|
|
self.scheduler_api = rpcapi.SchedulerAPI()
|
|
self._view_builder_class = scheduler_stats_views.ViewBuilder
|
|
super(SchedulerStatsController, self).__init__()
|
|
|
|
@wsgi.Controller.api_version('1.0', '2.22')
|
|
@wsgi.Controller.authorize('index')
|
|
def pools_index(self, req):
|
|
"""Returns a list of storage pools known to the scheduler."""
|
|
return self._pools(req, action='index')
|
|
|
|
@wsgi.Controller.api_version('2.23') # noqa
|
|
@wsgi.Controller.authorize('index')
|
|
def pools_index(self, req): # pylint: disable=function-redefined # noqa F811
|
|
return self._pools(req, action='index', enable_share_type=True)
|
|
|
|
@wsgi.Controller.api_version('1.0', '2.22')
|
|
@wsgi.Controller.authorize('detail')
|
|
def pools_detail(self, req):
|
|
"""Returns a detailed list of storage pools known to the scheduler."""
|
|
return self._pools(req, action='detail')
|
|
|
|
@wsgi.Controller.api_version('2.23') # noqa
|
|
@wsgi.Controller.authorize('detail')
|
|
def pools_detail(self, req): # pylint: disable=function-redefined # noqa F811
|
|
return self._pools(req, action='detail', enable_share_type=True)
|
|
|
|
def _pools(self, req, action='index', enable_share_type=False):
|
|
context = req.environ['manila.context']
|
|
search_opts = {}
|
|
search_opts.update(req.GET)
|
|
|
|
if enable_share_type:
|
|
req_share_type = search_opts.pop('share_type', None)
|
|
if req_share_type:
|
|
try:
|
|
share_type = share_types.get_share_type_by_name_or_id(
|
|
context, req_share_type)
|
|
|
|
search_opts['capabilities'] = share_type.get('extra_specs',
|
|
{})
|
|
except exception.ShareTypeNotFound:
|
|
msg = _("Share type %s not found.") % req_share_type
|
|
raise exc.HTTPBadRequest(explanation=msg)
|
|
|
|
try:
|
|
pools = self.scheduler_api.get_pools(context,
|
|
filters=search_opts,
|
|
cached=True)
|
|
except exception.NotAuthorized:
|
|
raise exc.HTTPForbidden()
|
|
detail = (action == 'detail')
|
|
return self._view_builder.pools(pools, detail=detail)
|
|
|
|
|
|
def create_resource():
|
|
return wsgi.Resource(SchedulerStatsController())
|