manila/4e377e556b3d97912a9a3caad9a3da522335dabe

{
  "comments": [
    {
      "unresolved": true,
      "key": {
        "uuid": "e47ef4a1_0eaf9e4d",
        "filename": "/COMMIT_MSG",
        "patchSetId": 4
      },
      "lineNbr": 18,
      "author": {
        "id": 16643
      },
      "writtenOn": "2024-04-09T18:49:27Z",
      "side": 1,
      "message": "you still need this",
      "range": {
        "startLine": 18,
        "startChar": 0,
        "endLine": 18,
        "endChar": 53
      },
      "revId": "4e377e556b3d97912a9a3caad9a3da522335dabe",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
    },
    {
      "unresolved": false,
      "key": {
        "uuid": "d7149b3b_1208ce42",
        "filename": "/PATCHSET_LEVEL",
        "patchSetId": 4
      },
      "lineNbr": 0,
      "author": {
        "id": 16643
      },
      "writtenOn": "2024-04-04T20:08:13Z",
      "side": 1,
      "message": "Thanks Elvis, some comments inline",
      "revId": "4e377e556b3d97912a9a3caad9a3da522335dabe",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
    },
    {
      "unresolved": true,
      "key": {
        "uuid": "7fa4f452_f5c4d00a",
        "filename": "manila/share/drivers/qnap/api.py",
        "patchSetId": 4
      },
      "lineNbr": 24,
      "author": {
        "id": 16643
      },
      "writtenOn": "2024-04-04T20:08:13Z",
      "side": 1,
      "message": "The imports here are messed up; can you please fix them. \n\nImports are broken into three groups by convention: https://docs.openstack.org/hacking/latest/user/hacking.html#imports",
      "revId": "4e377e556b3d97912a9a3caad9a3da522335dabe",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
    },
    {
      "unresolved": true,
      "key": {
        "uuid": "271000da_9e4b0df4",
        "filename": "manila/share/drivers/qnap/api.py",
        "patchSetId": 4
      },
      "lineNbr": 24,
      "author": {
        "id": 36758
      },
      "writtenOn": "2024-04-09T18:05:31Z",
      "side": 1,
      "message": "I think it follows the OpenStack Style Guidelines. Can you elaborate more on what is wrong?",
      "parentUuid": "7fa4f452_f5c4d00a",
      "revId": "4e377e556b3d97912a9a3caad9a3da522335dabe",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
    },
    {
      "unresolved": false,
      "key": {
        "uuid": "1f96da24_c370603e",
        "filename": "manila/share/drivers/qnap/api.py",
        "patchSetId": 4
      },
      "lineNbr": 24,
      "author": {
        "id": 16643
      },
      "writtenOn": "2024-04-09T18:49:27Z",
      "side": 1,
      "message": "My bad; this import order conforms to our guidelines.",
      "parentUuid": "271000da_9e4b0df4",
      "revId": "4e377e556b3d97912a9a3caad9a3da522335dabe",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
    },
    {
      "unresolved": true,
      "key": {
        "uuid": "1ba2c631_3d62b134",
        "filename": "manila/share/drivers/qnap/api.py",
        "patchSetId": 4
      },
      "lineNbr": 25,
      "author": {
        "id": 16643
      },
      "writtenOn": "2024-04-04T20:08:13Z",
      "side": 1,
      "message": "we have a convention to not import objects; we import modules and use the objects from them.. please do:\n\n```\nfrom defusedxml import ElementTree as ET\n```\n\nand all these lines of code using \"ET.fromstring\" needn\u0027t be changed\n\nalthough, I would rather prefer:\n\n```\nfrom defusedxml import ElementTree as etree\n```\n\nand modifying the code to use:\n\n```\netree.fromstring(..)\n```",
      "range": {
        "startLine": 25,
        "startChar": 0,
        "endLine": 25,
        "endChar": 45
      },
      "revId": "4e377e556b3d97912a9a3caad9a3da522335dabe",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
    },
    {
      "unresolved": false,
      "key": {
        "uuid": "b78ce9e8_01ca1a6c",
        "filename": "manila/share/drivers/qnap/api.py",
        "patchSetId": 4
      },
      "lineNbr": 25,
      "author": {
        "id": 36758
      },
      "writtenOn": "2024-04-09T18:05:31Z",
      "side": 1,
      "message": "Done",
      "parentUuid": "1ba2c631_3d62b134",
      "range": {
        "startLine": 25,
        "startChar": 0,
        "endLine": 25,
        "endChar": 45
      },
      "revId": "4e377e556b3d97912a9a3caad9a3da522335dabe",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
    }
  ]
}