da0b4d66c9
This change imports two functions and a class from the microversion handling implementation in the placement service. This code should be generally useful for other implementations. The added code provides functions for not just extracting the microversion from HTTP headers, but for validating that the found information is actually a properly formed microversion value. 'latest' is translated to whatever latest is in an ordered list of versions and any found version is confirmed to be within the bounds of and a member of that list of versions. The README.rst has been updated to reflect the newly available methods. This is a start at documentation, but we'll probably want more. Change-Id: I267586c78308cc5520a88598c350a7e055783f3e
117 lines
4.1 KiB
Python
117 lines
4.1 KiB
Python
# Licensed under the Apache License, Version 2.0 (the "License");
|
|
# you may not use this file except in compliance with the License.
|
|
# You may obtain a copy of the License at
|
|
#
|
|
# http://www.apache.org/licenses/LICENSE-2.0
|
|
#
|
|
# Unless required by applicable law or agreed to in writing, software
|
|
# distributed under the License is distributed on an "AS IS" BASIS,
|
|
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or
|
|
# implied.
|
|
# See the License for the specific language governing permissions and
|
|
# limitations under the License.
|
|
|
|
|
|
import testtools
|
|
|
|
import microversion_parse
|
|
|
|
|
|
class TestVersion(testtools.TestCase):
|
|
|
|
def setUp(self):
|
|
super(TestVersion, self).setUp()
|
|
self.version = microversion_parse.Version(1, 5)
|
|
|
|
def test_version_is_tuple(self):
|
|
self.assertEqual((1, 5), self.version)
|
|
|
|
def test_version_stringifies(self):
|
|
self.assertEqual('1.5', str(self.version))
|
|
|
|
def test_version_matches(self):
|
|
max_version = microversion_parse.Version(1, 20)
|
|
min_version = microversion_parse.Version(1, 3)
|
|
|
|
self.assertTrue(self.version.matches(min_version, max_version))
|
|
self.assertFalse(self.version.matches(max_version, min_version))
|
|
|
|
def test_version_matches_inclusive(self):
|
|
max_version = microversion_parse.Version(1, 5)
|
|
min_version = microversion_parse.Version(1, 5)
|
|
|
|
self.assertTrue(self.version.matches(min_version, max_version))
|
|
|
|
def test_version_init_failure(self):
|
|
self.assertRaises(TypeError, microversion_parse.Version, 1, 2, 3)
|
|
|
|
|
|
class TestParseVersionString(testtools.TestCase):
|
|
|
|
def test_good_version(self):
|
|
version = microversion_parse.parse_version_string('1.1')
|
|
self.assertEqual((1, 1), version)
|
|
self.assertEqual(microversion_parse.Version(1, 1), version)
|
|
|
|
def test_adapt_whitespace(self):
|
|
version = microversion_parse.parse_version_string(' 1.1 ')
|
|
self.assertEqual((1, 1), version)
|
|
self.assertEqual(microversion_parse.Version(1, 1), version)
|
|
|
|
def test_non_numeric(self):
|
|
self.assertRaises(TypeError,
|
|
microversion_parse.parse_version_string,
|
|
'hello')
|
|
|
|
def test_mixed_alphanumeric(self):
|
|
self.assertRaises(TypeError,
|
|
microversion_parse.parse_version_string,
|
|
'1.a')
|
|
|
|
def test_too_many_numeric(self):
|
|
self.assertRaises(TypeError,
|
|
microversion_parse.parse_version_string,
|
|
'1.1.1')
|
|
|
|
def test_not_string(self):
|
|
self.assertRaises(TypeError,
|
|
microversion_parse.parse_version_string,
|
|
1.1)
|
|
|
|
|
|
class TestExtractVersion(testtools.TestCase):
|
|
|
|
def setUp(self):
|
|
super(TestExtractVersion, self).setUp()
|
|
self.headers = [
|
|
('OpenStack-API-Version', 'service1 1.2'),
|
|
('OpenStack-API-Version', 'service2 1.5'),
|
|
('OpenStack-API-Version', 'service3 latest'),
|
|
('OpenStack-API-Version', 'service4 2.5'),
|
|
]
|
|
self.version_list = ['1.1', '1.2', '1.3', '1.4',
|
|
'2.1', '2.2', '2.3', '2.4']
|
|
|
|
def test_simple_extract(self):
|
|
version = microversion_parse.extract_version(
|
|
self.headers, 'service1', self.version_list)
|
|
self.assertEqual((1, 2), version)
|
|
|
|
def test_default_min(self):
|
|
version = microversion_parse.extract_version(
|
|
self.headers, 'notlisted', self.version_list)
|
|
self.assertEqual((1, 1), version)
|
|
|
|
def test_latest(self):
|
|
version = microversion_parse.extract_version(
|
|
self.headers, 'service3', self.version_list)
|
|
self.assertEqual((2, 4), version)
|
|
|
|
def test_version_disabled(self):
|
|
self.assertRaises(ValueError, microversion_parse.extract_version,
|
|
self.headers, 'service2', self.version_list)
|
|
|
|
def test_version_out_of_range(self):
|
|
self.assertRaises(ValueError, microversion_parse.extract_version,
|
|
self.headers, 'service4', self.version_list)
|