diff --git a/mistraldashboard/action_executions/tables.py b/mistraldashboard/action_executions/tables.py index 221af9d..d7a4c77 100644 --- a/mistraldashboard/action_executions/tables.py +++ b/mistraldashboard/action_executions/tables.py @@ -80,8 +80,7 @@ class ActionExecutionsTable(tables.DataTable): def getHoverHelp(data): if hasattr(data, 'state_info') and data.state_info: - - return {'title': data.state_info} + return {'title': data.state_info} STATE_STATUS_CHOICES = ( ("success", True), diff --git a/mistraldashboard/default/smart_cell.py b/mistraldashboard/default/smart_cell.py index 56460bc..0b44ec6 100644 --- a/mistraldashboard/default/smart_cell.py +++ b/mistraldashboard/default/smart_cell.py @@ -53,9 +53,9 @@ def get_data(self, datum, column, row): if (template.defaultfilters.urlize in column.filters or template.defaultfilters.yesno in column.filters): - data = widget.render(widget_name, - column.get_raw_data(datum), - form_field_attributes) + data = widget.render(widget_name, + column.get_raw_data(datum), + form_field_attributes) else: data = widget.render(widget_name, column.get_data(datum), diff --git a/mistraldashboard/executions/tables.py b/mistraldashboard/executions/tables.py index de61d21..e0d8991 100644 --- a/mistraldashboard/executions/tables.py +++ b/mistraldashboard/executions/tables.py @@ -155,8 +155,7 @@ class ExecutionsTable(tables.DataTable): def getHoverHelp(data): if hasattr(data, 'state_info') and data.state_info: - - return {'title': data.state_info} + return {'title': data.state_info} STATE_STATUS_CHOICES = ( ("success", True), diff --git a/mistraldashboard/tasks/tables.py b/mistraldashboard/tasks/tables.py index 976980b..c98b24a 100644 --- a/mistraldashboard/tasks/tables.py +++ b/mistraldashboard/tasks/tables.py @@ -57,8 +57,7 @@ class TaskTable(tables.DataTable): def getHoverHelp(data): if hasattr(data, 'state_info') and data.state_info: - - return {'title': data.state_info} + return {'title': data.state_info} STATE_STATUS_CHOICES = ( ("success", True), diff --git a/mistraldashboard/test/settings.py b/mistraldashboard/test/settings.py index 37bba8f..77b0544 100644 --- a/mistraldashboard/test/settings.py +++ b/mistraldashboard/test/settings.py @@ -16,5 +16,5 @@ from horizon.test.settings import * # noqa from openstack_dashboard.test.settings import * # noqa -INSTALLED_APPS = list(INSTALLED_APPS) # noqa: F999 +INSTALLED_APPS = list(INSTALLED_APPS) # noqa: F405 INSTALLED_APPS.append('mistraldashboard') diff --git a/test-requirements.txt b/test-requirements.txt index 87fced8..02499b8 100644 --- a/test-requirements.txt +++ b/test-requirements.txt @@ -2,12 +2,8 @@ # of appearance. Changing the order has an impact on the overall integration # process, which may cause wedges in the gate later. -# Hacking already pins down pep8, pyflakes and flake8 -hacking!=0.13.0,<0.14,>=0.12.0 # Apache-2.0 -# remove this pyflakes from here once you bump the -# hacking to 3.2.0 or above. hacking 3.2.0 takes -# care of pyflakes version compatibilty. -pyflakes>=2.1.1 +# hacking should appear first in case something else depends on pep8 +hacking>=4.0.0,<4.1.0 # Apache-2.0 # Testing Requirements coverage!=4.4,>=4.0 # Apache-2.0 diff --git a/tox.ini b/tox.ini index 02fa9f2..0511582 100644 --- a/tox.ini +++ b/tox.ini @@ -2,16 +2,16 @@ minversion = 2.0 envlist = pep8,py38 skipsdist = True +ignore_basepython_conflict = true [testenv] basepython = python3 usedevelop = True -install_command = pip install -c{env:TOX_CONSTRAINTS_FILE:https://releases.openstack.org/constraints/upper/victoria} {opts} {packages} setenv = VIRTUAL_ENV={envdir} -deps = -r{toxinidir}/requirements.txt +deps = -c{env:TOX_CONSTRAINTS_FILE:https://releases.openstack.org/constraints/upper/victoria} + -r{toxinidir}/requirements.txt -r{toxinidir}/test-requirements.txt - http://tarballs.openstack.org/horizon/horizon-master.tar.gz commands = find . -type f -name "*.pyc" -delete /bin/bash run_tests.sh -N --no-pep8 {posargs}