From 91fac9f1b1b21aebc5472e995486f871fe5349bd Mon Sep 17 00:00:00 2001 From: Gal Margalit Date: Tue, 6 Dec 2016 15:50:37 +0000 Subject: [PATCH] mistral-dashboard:fixed boolean field design bug * boolean field design - removed the false check from detail screens, it is actually a bug: false is a valid value - and has a matching design. Change-Id: Ifbec1757026f69abe6035ca35d0275c534e09b71 --- mistraldashboard/action_executions/views.py | 7 +++---- mistraldashboard/actions/views.py | 3 +-- 2 files changed, 4 insertions(+), 6 deletions(-) diff --git a/mistraldashboard/action_executions/views.py b/mistraldashboard/action_executions/views.py index 8273eb3..647344d 100644 --- a/mistraldashboard/action_executions/views.py +++ b/mistraldashboard/action_executions/views.py @@ -75,10 +75,9 @@ class OverviewView(generic.TemplateView): ) if action_execution.state: action_execution.state = utils.label(action_execution.state) - if action_execution.accepted: - action_execution.accepted = utils.booleanfield( - action_execution.accepted - ) + action_execution.accepted = utils.booleanfield( + action_execution.accepted + ) breadcrumb = [(action_execution.id, reverse( 'horizon:mistral:action_executions:detail', diff --git a/mistraldashboard/actions/views.py b/mistraldashboard/actions/views.py index a5afb75..1e01561 100644 --- a/mistraldashboard/actions/views.py +++ b/mistraldashboard/actions/views.py @@ -113,8 +113,7 @@ class DetailView(generic.TemplateView): def get_context_data(self, **kwargs): context = super(DetailView, self).get_context_data(**kwargs) action = self.get_data(self.request, **kwargs) - if action.is_system: - action.is_system = utils.booleanfield(action.is_system) + action.is_system = utils.booleanfield(action.is_system) breadcrumb = [(action.name, reverse( 'horizon:mistral:actions:detail', args=[action.id]