openstack
/
mistral-dashboard
Code Issues Proposed changes

mistral-dashboard:fixed boolean field design bug 

* boolean field design - removed the false check from detail screens,
  it is actually a bug: false is a valid value - and has a matching
  design.

Change-Id: Ifbec1757026f69abe6035ca35d0275c534e09b71
This commit is contained in:
Gal Margalit 2016-12-06 15:50:37 +00:00
parent 6c6346f9a0
commit 91fac9f1b1
2 changed files with 4 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
mistraldashboard/action_executions/views.py
View File

@ -75,10 +75,9 @@ class OverviewView(generic.TemplateView):
) )
if action_execution.state: if action_execution.state:
action_execution.state = utils.label(action_execution.state) action_execution.state = utils.label(action_execution.state)
if action_execution.accepted: action_execution.accepted = utils.booleanfield(
action_execution.accepted = utils.booleanfield( action_execution.accepted
action_execution.accepted )
)
breadcrumb = [(action_execution.id, reverse( breadcrumb = [(action_execution.id, reverse(
'horizon:mistral:action_executions:detail', 'horizon:mistral:action_executions:detail',

3
mistraldashboard/actions/views.py
View File

@ -113,8 +113,7 @@ class DetailView(generic.TemplateView):
def get_context_data(self, **kwargs): def get_context_data(self, **kwargs):
context = super(DetailView, self).get_context_data(**kwargs) context = super(DetailView, self).get_context_data(**kwargs)
action = self.get_data(self.request, **kwargs) action = self.get_data(self.request, **kwargs)
if action.is_system: action.is_system = utils.booleanfield(action.is_system)
action.is_system = utils.booleanfield(action.is_system)
breadcrumb = [(action.name, reverse( breadcrumb = [(action.name, reverse(
'horizon:mistral:actions:detail', 'horizon:mistral:actions:detail',
args=[action.id] args=[action.id]