openstack/mistral
Code Issues Proposed changes

Implement policy in code - workbook (9)

Browse Source 
This commit migrate all workbook policies into code [1].

Like oslo.config, with oslo.policy, we can define all of
default rules in code base and only change some rules
via policy file. Another thing that we should use yaml
format instead of json format.

[1] https://governance.openstack.org/tc/goals/queens/policy-in-code.html
Co-authored-By: Dai Dang-Van <daidv@vn.fujitsu.com>

Change-Id: I267a528322cdf69f132503112bb7124ec882ce80
This commit is contained in:
Hieu LE 2017-10-13 11:46:59 +07:00 committed by Dai Dang Van
parent 643da24ff2
commit 0f6241b031
4 changed files with 83 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
etc/policy.json
View File

@ -1,12 +1,6 @@
{
"default": "rule:admin_or_owner",
"workbooks:create": "rule:admin_or_owner",
"workbooks:delete": "rule:admin_or_owner",
"workbooks:get": "rule:admin_or_owner",
"workbooks:list": "rule:admin_or_owner",
"workbooks:update": "rule:admin_or_owner",
"workflows:create": "rule:admin_or_owner",
"workflows:delete": "rule:admin_or_owner",
"workflows:get": "rule:admin_or_owner",

4
mistral/policies/__init__.py
View File

@ -23,6 +23,7 @@ from mistral.policies import execution
from mistral.policies import member
from mistral.policies import service
from mistral.policies import task
from mistral.policies import workbook
def list_rules():
@ -35,5 +36,6 @@ def list_rules():
execution.list_rules(),
member.list_rules(),
service.list_rules(),
task.list_rules()
task.list_rules(),
workbook.list_rules()
)

80
mistral/policies/workbook.py Normal file
View File

@ -0,0 +1,80 @@
# All Rights Reserved.
#
# Licensed under the Apache License, Version 2.0 (the "License"); you may
# not use this file except in compliance with the License. You may obtain
# a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
# License for the specific language governing permissions and limitations
# under the License.
from oslo_policy import policy
from mistral.policies import base
WORKBOOKS = 'workbooks:%s'
rules = [
policy.DocumentedRuleDefault(
name=WORKBOOKS % 'create',
check_str=base.RULE_ADMIN_OR_OWNER,
description='Create a new workbook.',
operations=[
{
'path': '/v2/workbooks',
'method': 'POST'
}
]
),
policy.DocumentedRuleDefault(
name=WORKBOOKS % 'delete',
check_str=base.RULE_ADMIN_OR_OWNER,
description='Delete the named workbook.',
operations=[
{
'path': '/v2/workbooks',
'method': 'DELETE'
}
]
),
policy.DocumentedRuleDefault(
name=WORKBOOKS % 'get',
check_str=base.RULE_ADMIN_OR_OWNER,
description='Return the named workbook.',
operations=[
{
'path': '/v2/workbooks/{workbook_name}',
'method': 'GET'
}
]
),
policy.DocumentedRuleDefault(
name=WORKBOOKS % 'list',
check_str=base.RULE_ADMIN_OR_OWNER,
description='Return all workbooks.',
operations=[
{
'path': '/v2/workbooks',
'method': 'GET'
}
]
),
policy.DocumentedRuleDefault(
name=WORKBOOKS % 'update',
check_str=base.RULE_ADMIN_OR_OWNER,
description='Update an workbook.',
operations=[
{
'path': '/v2/workbooks',
'method': 'PUT'
}
]
)
]
def list_rules():
return rules

6
mistral/tests/unit/fake_policy.py
View File

@ -15,12 +15,6 @@
policy_data = """{
"default": "rule:admin_or_owner",
"workbooks:create": "rule:admin_or_owner",
"workbooks:delete": "rule:admin_or_owner",
"workbooks:get": "rule:admin_or_owner",
"workbooks:list": "rule:admin_or_owner",
"workbooks:update": "rule:admin_or_owner",
"workflows:create": "rule:admin_or_owner",
"workflows:delete": "rule:admin_or_owner",
"workflows:get": "rule:admin_or_owner",