openstack/mistral
Code Issues Proposed changes

Correct the string formatting in a info log message

Browse Source 
It should be "%s," not just "%,". The error observed was something
like...

ValueError: unsupported format character ',' (0x2c) at index 91

Closes-Bug: #1764696
Change-Id: I601c8640cec857746c2c17f94116da890f4d65e0
This commit is contained in:
Dougal Matthews 2018-04-17 10:31:55 +01:00
parent a28f42f442
commit 15e95d9b3c
2 changed files with 7 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
mistral/db/v2/sqlalchemy/api.py
View File

@ -180,7 +180,7 @@ def update_on_match(id, specimen, values, session=None):
except oslo_sqlalchemy.update_match.NoRowsMatched: except oslo_sqlalchemy.update_match.NoRowsMatched:
LOG.info( LOG.info(
"Can't change state of persistent object " "Can't change state of persistent object "
"because it has already been changed. [model_class=%, id=%s, " "because it has already been changed. [model_class=%s, id=%s, "
"specimen=%s, values=%s]", "specimen=%s, values=%s]",
model_class, id, specimen, values model_class, id, specimen, values
) )

6
releasenotes/notes/fix-regression-when-logging-58faa35f02cefb34.yaml Normal file
View File

@ -0,0 +1,6 @@
---
fixes:
- |
A regression was introduced that caused an error when logging a specific
message. The string formatting was broken, which caused the logging to
fail.