openstack
/
mistral
Code Issues Proposed changes

Using assertIsNone() instead of assertEqual(None, ...) 

Following OpenStack Style Guidelines[1]:
[H203] Unit test assertions tend to give better messages for more
specific assertions. As a result, assertIsNone(...) is preferred
over assertEqual(None, ...) and assertIs(None, ...)

[1] http://docs.openstack.org/developer/hacking/#unit-tests-and-assertraises

Change-Id: I57c45877df8055911c28b31a679549d65398a18e
This commit is contained in:
Cao Xuan Hoang 2016-09-28 09:32:36 +07:00
parent 75367cc08e
commit 2277b294db
2 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
mistral/tests/unit/engine/rpc_backend/kombu/test_kombu_client.py
View File

@ -120,7 +120,7 @@ class KombuClientTestCase(base.KombuTestCase):
get_thread_local.side_effect = side_effect
response = self.client.async_call(self.ctx, 'method')
self.assertEqual(response, None)
self.assertIsNone(response)
# check if consumer.consume was called once
self.assertEqual(self.client.consumer.consume.call_count, 1)

2
mistral/tests/unit/engine/rpc_backend/kombu/test_kombu_server.py
View File

@ -122,7 +122,7 @@ class KombuServerTestCase(base.KombuTestCase):
acquire_mock.drain_events.side_effect = KeyboardInterrupt()
fake_kombu.connection.acquire.return_value = acquire_mock
self.assertEqual(self.server.run(), None)
self.assertIsNone(self.server.run())
self.assertFalse(self.server.is_running)
@mock.patch.object(