From 66f6c90f6655b8274f8d81b56375649ab3a3b3e9 Mon Sep 17 00:00:00 2001 From: Andras Kovi Date: Mon, 30 Jul 2018 14:03:09 +0200 Subject: [PATCH] Fix flaky cron trigger test Checking for equality of times is flaky because if the samplig happens around the boundady of a second, then it can cause an off by 1 error. The test is modified to tolerate these errors. Change-Id: Ib341b0ae4bff6f74c412f62678a5a663a99b0b0b --- mistral/tests/unit/engine/test_cron_trigger.py | 15 +++++++-------- 1 file changed, 7 insertions(+), 8 deletions(-) diff --git a/mistral/tests/unit/engine/test_cron_trigger.py b/mistral/tests/unit/engine/test_cron_trigger.py index a33de88d7..5bfeef1a9 100644 --- a/mistral/tests/unit/engine/test_cron_trigger.py +++ b/mistral/tests/unit/engine/test_cron_trigger.py @@ -175,10 +175,9 @@ class ProcessCronTriggerTest(base.EngineTestCase): None ) - self.assertEqual( - first_time, - cron_trigger.next_execution_time - ) + interval = (cron_trigger.next_execution_time - first_time) + + self.assertLessEqual(interval.total_seconds(), 3.0) periodic.process_cron_triggers_v2(None, None) @@ -193,10 +192,10 @@ class ProcessCronTriggerTest(base.EngineTestCase): cron_trigger_db = db_api.get_cron_trigger(trigger_name) self.assertIsNotNone(cron_trigger_db) - self.assertEqual( - next_time, - cron_trigger_db.next_execution_time - ) + + interval = (cron_trigger_db.next_execution_time - next_time) + + self.assertLessEqual(interval.total_seconds(), 3.0) def test_validate_cron_trigger_input_first_time(self): cfg.CONF.set_default('auth_enable', False, group='pecan')