openstack/mistral
Code Issues Proposed changes

Remove environment data from task inbound context

Browse Source 
* It's redundant to keep environment data in task inbound context,
  it is immutable and we can always take it from workflow execution
  object which is more efficient from DB space consumption
  standpoint. The only case when it's allowed to modify data
  in a workflow environment is when we either resume or re-run
  a workflow and in this case we can change it for the whole
  workflow execution.

Change-Id: I244c1768aaa306f8ad41084325107a40005d874c
This commit is contained in:
Renat Akhmerov
2016-09-26 13:22:09 +03:00
parent bdb357f24a
commit bdf49b7193
4 changed files with 11 additions and 37 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
mistral/workflow/base.py
View File

@@ -16,7 +16,6 @@
# limitations under the License.
import abc
import copy
from oslo_log import log as logging
from osprofiler import profiler
@@ -182,19 +181,7 @@ class WorkflowController(object):
# to cover 'split' (aka 'merge') use case.
upstream_task_execs = self._get_upstream_task_executions(task_spec)
ctx = data_flow.evaluate_upstream_context(upstream_task_execs)
# TODO(rakhmerov): Seems like we can fully get rid of '__env' in
# task context if we are OK to have it only in workflow execution
# object (wf_ex.context). Now we can selectively modify env
# for some tasks if we resume or re-run a workflow.
if self.wf_ex.context:
ctx['__env'] = u.merge_dicts(
copy.deepcopy(ctx.get('__env', {})),
copy.deepcopy(self.wf_ex.context.get('__env', {}))
)
return ctx
return data_flow.evaluate_upstream_context(upstream_task_execs)
@abc.abstractmethod
def _get_upstream_task_executions(self, task_spec):