mistral/mistral/tests/unit/api/test_resource_base.py
ali 4a6309683b wrapped the value of parameters in inputs(in wf get API) with "".
the input field of workflow-get API is ambiguous, and not well defined,
 2 different inputs can have the same value for the input field.

 for example :

   input:
     - first
     - second: "value, third"

  and:

    input:
     - first
     - second: "value"
     - third

 for both it was: input ="first, second=value, third"

 now it is:
 for the first: input ="first, second=\"value, third\""
 and for the second: input ="first, second=\"value\", third"

 Closes-Bug: 1631541

Change-Id: I4b3fc7e0ad4552022d44c3bdd8c87004f5e8ff46
Signed-off-by: ali <ali.abdelal@nokia.com>
2020-01-19 14:20:51 +00:00

190 lines
4.8 KiB
Python

# Copyright 2016 NEC Corporation. All rights reserved.
#
# Licensed under the Apache License, Version 2.0 (the "License"); you may
# not use this file except in compliance with the License. You may obtain
# a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
# License for the specific language governing permissions and limitations
# under the License.
import copy
import datetime
from mistral.api.controllers.v2 import resources
from mistral.db.v2 import api as db_api
from mistral.services import workflows as wf_service
from mistral.tests.unit import base
from mistral_lib import utils
WF_EXEC = {
'id': 'c0f3be41-88b9-4c86-a669-83e77cd0a1b8',
'spec': {},
'params': {'task': 'my_task1'},
'project_id': '<default-project>',
'scope': 'PUBLIC',
'state': 'IDLE',
'state_info': "Running...",
'created_at': datetime.datetime(2016, 12, 1, 15, 0, 0),
'updated_at': None,
'context': None,
'task_execution_id': None,
'description': None,
'output': None,
'accepted': False,
'some_invalid_field': "foobar"
}
WF = """---
version: '2.0'
WF:
type: direct
input:
- no_default_value_input
- string_param: "string"
- json_param: {
string_param: "string"
}
output:
output1: 'output'
tasks:
task1:
action: std.noop
"""
WF_NO_PARAMS = """---
version: '2.0'
WF_NO_PARAMS:
type: direct
tasks:
task1:
action: std.noop
"""
WF_WITH_INPUT = """---
version: '2.0'
WF_2_PARAMS:
type: direct
input:
- param1
- param2: "value, param"
tasks:
task1:
action: std.noop
WF_3_PARAMS:
type: direct
input:
- param1
- param2: "value"
- param
tasks:
task1:
action: std.noop
"""
class TestRestResource(base.DbTestCase):
def test_from_db_model(self):
wf_ex = db_api.create_workflow_execution(WF_EXEC)
self.assertIsNotNone(wf_ex)
wf_ex_resource = resources.Execution.from_db_model(wf_ex)
self.assertIsNotNone(wf_ex_resource)
expected = copy.copy(WF_EXEC)
del expected['some_invalid_field']
utils.datetime_to_str_in_dict(expected, 'created_at')
self.assertDictEqual(expected, wf_ex.to_dict())
def test_from_db_model_workflow_resource(self):
expected_interface = {
'output': ['output1'],
'input': [
'no_default_value_input',
{'string_param': 'string'},
{
'json_param': {'string_param': 'string'}
}
]
}
workflows_list = wf_service.create_workflows(WF)
self.assertEqual(1, len(workflows_list))
wf_resource = resources.Workflow.from_db_model(workflows_list[0])
self.assertDictEqual(expected_interface, wf_resource.interface)
def test_from_db_model_workflow_resource_no_params(self):
expected_interface = {
'input': [],
'output': []
}
workflows_list = wf_service.create_workflows(WF_NO_PARAMS)
self.assertEqual(1, len(workflows_list))
wf_resource = resources.Workflow.from_db_model(workflows_list[0])
self.assertDictEqual(expected_interface, wf_resource.interface)
def test_from_db_model_workflow_with_input(self):
expected_input_two_params = "param1, param2=\"value, param\""
expected_input_three_params = "param1, param2=\"value\", param"
workflows_list = wf_service.create_workflows(WF_WITH_INPUT)
self.assertEqual(2, len(workflows_list))
wf_two_params = workflows_list[0] \
if workflows_list[0].name == 'WF_2_PARAMS' \
else workflows_list[1]
wf_three_params = workflows_list[0] \
if workflows_list[0].name == 'WF_3_PARAMS' \
else workflows_list[1]
two_params_wf_resource = resources.Workflow.from_db_model(
wf_two_params)
three_params_wf_resource = resources.Workflow.from_db_model(
wf_three_params)
self.assertEqual(expected_input_two_params,
two_params_wf_resource.input)
self.assertEqual(expected_input_three_params,
three_params_wf_resource.input)
def test_from_dict(self):
wf_ex = db_api.create_workflow_execution(WF_EXEC)
self.assertIsNotNone(wf_ex)
wf_ex_resource = resources.Execution.from_dict(wf_ex.to_dict())
self.assertIsNotNone(wf_ex_resource)
expected = copy.copy(WF_EXEC)
del expected['some_invalid_field']
utils.datetime_to_str_in_dict(expected, 'created_at')
self.assertDictEqual(expected, wf_ex.to_dict())