From 1e21de689abc0eb1c8f78a9e674c2f25b79f1cb8 Mon Sep 17 00:00:00 2001 From: wanghuagong Date: Thu, 13 Apr 2017 15:50:23 +0800 Subject: [PATCH] Fix AttributeError: 'virDomain' object has no attribute 'id' When checking 'libvirt' instance and inspecting disk info, monasca_agent collector complains errors "AttributeError: 'virDomain' object has no attribute 'id'". Because 'instance' has no attribute 'id', so 'instance.id' will lead to errors. We can use 'instance.ID()' to get an instance uuid. Change-Id: Ife95c2a976a99bb73e71a3764fa1c4f5d26cc36e Story: 2000987 Task: 4164 Closes-Bug:#1682354 --- monasca_agent/collector/virt/libvirt/inspector.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/monasca_agent/collector/virt/libvirt/inspector.py b/monasca_agent/collector/virt/libvirt/inspector.py index d9239a0e..63e6110d 100644 --- a/monasca_agent/collector/virt/libvirt/inspector.py +++ b/monasca_agent/collector/virt/libvirt/inspector.py @@ -206,7 +206,7 @@ class LibvirtInspector(virt_inspector.Inspector): if disk_type == 'network': log.debug('Inspection disk usage of network disk ' '%(instance_uuid)s unsupported by libvirt' % { - 'instance_uuid': instance.id}) + 'instance_uuid': instance.ID()}) continue target = disk.find('target') device = target.get('dev')