openstack
/
monasca-agent
Code Issues Proposed changes

Use HostAddressOpt for opts that accept IP and hostnames 

Some configuration options were accepting both IP addresses
and hostnames. Since there was no specific OSLO opt type to
support this, we were using ``StrOpt``. The change [1] that
added support for ``HostAddressOpt`` type was merged in Ocata
and became available for use with oslo version 3.22.

This patch changes the opt type of configuration options to use
this more relevant opt type - HostAddressOpt.

[1] I77bdb64b7e6e56ce761d76696bc4448a9bd325eb

Change-Id: I3b2239dbc19b3fc074702804c83a77ad4b269b94
This commit is contained in:
WangBinbin 2017-03-17 03:21:22 +08:00
parent 1bb63b85b1
commit 2f23d40dcf
2 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
monasca_agent/collector/virt/vmware/inspector.py
View File

@ -28,9 +28,9 @@ opt_group = cfg.OptGroup(name='vmware',
title='Options for VMware')
OPTS = [
cfg.StrOpt('host_ip',
default='',
help='IP address of the VMware Vsphere host.'),
cfg.HostAddressOpt('host_ip',
default='0.0.0.0',
help='IP address of the VMware Vsphere host.'),
cfg.IntOpt('host_port',
default=443,
help='Port of the VMware Vsphere host.'),

2
requirements.txt
View File

@ -4,7 +4,7 @@
requests>=2.10.0,!=2.12.2,!=2.13.0 # Apache-2.0
oslo.concurrency>=3.8.0 # Apache-2.0
oslo.config>=3.14.0,!=3.18.0 # Apache-2.0
oslo.config>=3.22.0 # Apache-2.0
oslo.i18n>=2.1.0 # Apache-2.0
oslo.utils>=3.18.0 # Apache-2.0
oslo.vmware>=2.11.0 # Apache-2.0