From b48e43eda628dadd4f789a69ea418e762f113981 Mon Sep 17 00:00:00 2001 From: ghanshyam Date: Tue, 16 Oct 2018 11:26:51 +0000 Subject: [PATCH] Gate fix: Cap hacking to avoid gate failure hacking is not capped in g-r and it is in blacklist for requirement as hacking new version can break the gate jobs. Hacking can break gate jobs because of various reasons: - There might be new rule addition in hacking - Some rules becomes default from non-default - Updates in pycodestyle etc That was the main reason it was not added in g-r auto sync also. Most of the project maintained the compatible and cap the hacking version in test-requirements.txt and update to new version when project is ready. Bumping new version might need code fix also on project side depends on what new in that version. If project does not have cap the hacking version then, there is possibility of gate failure whenever new hacking version is released by QA team. Example of such failure in recent release of hacking 1.1.0 - http://lists.openstack.org/pipermail/openstack-dev/2018-May/130282.html Change-Id: I4172dd0c905760dd84e5ff60d3fa052aae794edf --- test-requirements.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test-requirements.txt b/test-requirements.txt index 4b6a987..b7bf5b4 100644 --- a/test-requirements.txt +++ b/test-requirements.txt @@ -1,6 +1,6 @@ # mock object framework coverage>=3.6 # Apache-2.0 -hacking>=0.10.2 +hacking>=1.1.0,<1.2.0 flake8>=2.5.4,<=3.5.0 # MIT nose==1.3.0 mock>=1.0.1