diff --git a/monasca_tempest_tests/tests/api/test_statistics.py b/monasca_tempest_tests/tests/api/test_statistics.py index 77ae37206..c7e1286be 100644 --- a/monasca_tempest_tests/tests/api/test_statistics.py +++ b/monasca_tempest_tests/tests/api/test_statistics.py @@ -25,6 +25,8 @@ from tempest_lib import exceptions NUM_MEASUREMENTS = 100 WAIT_TIME = 30 +metric_value1 = 1.23 +metric_value2 = 4.56 class TestStatistics(base.BaseMonascaTest): @@ -32,21 +34,43 @@ class TestStatistics(base.BaseMonascaTest): @classmethod def resource_setup(cls): super(TestStatistics, cls).resource_setup() + name = data_utils.rand_name('name') + key = data_utils.rand_name('key') + value = data_utils.rand_name('value') + cls._test_name = name + cls._test_key = key + cls._test_value = value + cls._start_timestamp = int(time.time() * 1000) + metrics = [ + helpers.create_metric(name=cls._test_name, + dimensions={cls._test_key: cls._test_value}, + timestamp=cls._start_timestamp, + value=metric_value1), + helpers.create_metric(name=cls._test_name, + dimensions={cls._test_key: cls._test_value}, + timestamp=cls._start_timestamp + 1000, + value=metric_value2) + ] + cls.monasca_client.create_metrics(metrics) + start_time_iso = helpers.timestamp_to_iso(cls._start_timestamp) + query_param = '?name=' + str(name) + '&start_time=' + \ + start_time_iso + '&end_time=' + \ + helpers.timestamp_to_iso(cls._start_timestamp + 1000 * 2) + start_time_iso = helpers.timestamp_to_iso(cls._start_timestamp) + cls._start_time_iso = start_time_iso - start_timestamp = int(time.time() * 1000) - end_timestamp = int(time.time() * 1000) + NUM_MEASUREMENTS * 1000 - metrics = [] - - for i in xrange(NUM_MEASUREMENTS): - metric = helpers.create_metric( - name="name-1", - timestamp=start_timestamp + i) - metrics.append(metric) - - cls.monasca_client.create_metrics(metric) - cls._start_timestamp = start_timestamp - cls._end_timestamp = end_timestamp - cls._metrics = metrics + for i in xrange(constants.MAX_RETRIES): + resp, response_body = cls.monasca_client.\ + list_measurements(query_param) + elements = response_body['elements'] + for element in elements: + if str(element['name']) == name and len( + element['measurements']) == 2: + cls._end_timestamp = cls._start_timestamp + 1000 * 3 + cls._end_time_iso = helpers.timestamp_to_iso( + cls._end_timestamp) + return + time.sleep(constants.RETRY_WAIT_SECS) @classmethod def resource_cleanup(cls): @@ -54,110 +78,93 @@ class TestStatistics(base.BaseMonascaTest): @test.attr(type="gate") def test_list_statistics(self): - start_time = timeutils.iso8601_from_timestamp(self._start_timestamp / - 1000) - end_time = timeutils.iso8601_from_timestamp(self._end_timestamp / 1000) - query_parms = '?name=name-1&merge_metrics=true&statistics=avg' \ - '&start_time=' + str(start_time) + '&end_time=' \ - + str(end_time) + query_parms = '?name=' + str(self._test_name) + \ + '&statistics=avg,min,max,sum,count' + '&start_time=' + \ + str(self._start_time_iso) + '&end_time=' + \ + str(self._end_time_iso) + '&merge_metrics=true' + \ + '&period=100000' resp, response_body = self.monasca_client.list_statistics( query_parms) self.assertEqual(200, resp.status) - self.assertTrue(set(['links', 'elements']) == set(response_body)) - elements = response_body['elements'] - element = elements[0] - self.assertTrue(set(['id', 'name', 'dimensions', 'columns', - 'statistics']) == set(element)) - # check if 'id' is unicode type - self.assertTrue(type(element['id']) is unicode) - # check if 'name' is a string. NOPE its unicode - self.assertTrue(type(element['name']) is unicode) - self.assertTrue(type(element['dimensions']) is dict) - self.assertTrue(type(element['columns']) is list) - self.assertTrue(type(element['statistics']) is list) - statistic = element['statistics'] + element = response_body['elements'][0] + self._verify_element(element) column = element['columns'] - self.assertTrue(type(statistic) is list) - self.assertTrue(type(column) is list) + num_statistics_method = 5 + self._verify_column(column, num_statistics_method) + statistics = element['statistics'][0] + self._verify_statistics(statistics, metric_value1, metric_value2) @test.attr(type="gate") @test.attr(type=['negative']) def test_list_statistics_with_no_name(self): - start_time = timeutils.iso8601_from_timestamp(self._start_timestamp / - 1000) - end_time = timeutils.iso8601_from_timestamp(self._end_timestamp / 1000) query_parms = '?merge_metrics=true&statistics=avg&start_time=' + \ - str(start_time) + '&end_time=' + str(end_time) + str(self._start_time_iso) + '&end_time=' + \ + str(self._end_time_iso) self.assertRaises(exceptions.UnprocessableEntity, self.monasca_client.list_statistics, query_parms) @test.attr(type="gate") @test.attr(type=['negative']) def test_list_statistics_with_no_statistics(self): - start_time = timeutils.iso8601_from_timestamp(self._start_timestamp / - 1000) - end_time = timeutils.iso8601_from_timestamp(self._end_timestamp / 1000) - query_parms = '?name=name-1&start_time=' + str(start_time) + \ - '&end_time=' + str(end_time) + query_parms = '?name=' + str(self._test_name) + '&start_time=' + str( + self._start_time_iso) + '&end_time=' + str(self._end_time_iso) self.assertRaises(exceptions.UnprocessableEntity, self.monasca_client.list_statistics, query_parms) @test.attr(type="gate") @test.attr(type=['negative']) def test_list_statistics_with_no_start_time(self): - query_parms = '?name=name-1&statistics=avg' + query_parms = '?name=' + str(self._test_name) + '&statistics=avg' self.assertRaises(exceptions.UnprocessableEntity, self.monasca_client.list_statistics, query_parms) @test.attr(type="gate") @test.attr(type=['negative']) def test_list_statistics_with_invalid_statistics(self): - start_time = timeutils.iso8601_from_timestamp( - self._start_timestamp / 1000) - end_time = timeutils.iso8601_from_timestamp(self._end_timestamp / 1000) - query_parms = '?name=name-1&statistics=abc&start_time=' + str( - start_time) + '&end_time=' + str(end_time) + query_parms = '?name=' + str(self._test_name) + '&statistics=abc' + \ + '&start_time=' + str(self._start_time_iso) + \ + '&end_time=' + str(self._end_time_iso) self.assertRaises(exceptions.UnprocessableEntity, self.monasca_client.list_statistics, query_parms) @test.attr(type="gate") def test_list_statistics_with_dimensions(self): - start_time = timeutils.iso8601_from_timestamp(self._start_timestamp - / 1000) - end_time = timeutils.iso8601_from_timestamp(self._end_timestamp / 1000) - query_parms = '?name=name-1&merge_metrics=true&statistics=avg&' \ - 'start_time=' + str(start_time) + '&end_time=' + \ - str(end_time) + '&dimensions=key1:value1' + query_parms = '?name=' + str(self._test_name) + '&statistics=avg' \ + '&start_time=' + str(self._start_time_iso) + \ + '&end_time=' + str(self._end_time_iso) + \ + '&dimensions=' + str(self._test_key) + ':' + \ + str(self._test_value) + '&period=100000' resp, response_body = self.monasca_client.list_statistics( query_parms) self.assertEqual(200, resp.status) + dimensions = response_body['elements'][0]['dimensions'] + self.assertEqual(dimensions[self._test_key], self._test_value) @test.attr(type="gate") - def test_list_statistics_with_end_time(self): - start_time = timeutils.iso8601_from_timestamp( - self._start_timestamp / 1000) - end_time = timeutils.iso8601_from_timestamp( - self._end_timestamp / 1000) - query_parms = '?name=name-1&merge_metrics=true&statistics=avg&' \ - 'start_time=' + str(start_time) + '&end_time=' + \ - str(end_time) - resp, response_body = self.monasca_client.list_statistics( - query_parms) - self.assertEqual(200, resp.status) + @test.attr(type=['negative']) + def test_list_statistics_with_end_time_equals_start_time(self): + query_parms = '?name=' + str(self._test_name) + \ + '&merge_metrics=true&statistics=avg&' \ + 'start_time=' + str(self._start_time_iso) + \ + '&end_time=' + str(self._start_time_iso) + \ + '&period=100000' + self.assertRaises(exceptions.BadRequest, + self.monasca_client.list_statistics, query_parms) @test.attr(type="gate") def test_list_statistics_with_period(self): - start_time = timeutils.iso8601_from_timestamp( - self._start_timestamp / 1000) - end_time = timeutils.iso8601_from_timestamp( - self._end_timestamp / 1000) - query_parms = '?name=name-1&merge_metrics=true&statistics=avg&' \ - 'start_time=' + str(start_time) + '&end_time=' + \ - str(end_time) + '&period=300' + query_parms = '?name=' + str(self._test_name) + \ + '&merge_metrics=true&statistics=avg&' \ + 'start_time=' + str(self._start_time_iso) + \ + '&end_time=' + str(self._end_time_iso) + \ + '&period=1' resp, response_body = self.monasca_client.list_statistics( query_parms) self.assertEqual(200, resp.status) + time_diff = self._end_timestamp - self._start_timestamp + len_statistics = len(response_body['elements'][0]['statistics']) + self.assertEqual(time_diff / 1000, len_statistics) @test.attr(type="gate") def test_list_statistics_with_offset_limit(self): @@ -179,59 +186,36 @@ class TestStatistics(base.BaseMonascaTest): helpers.create_metric(name=name, timestamp=start_timestamp + 1500, dimensions={'key1': 'value-4', 'key2': 'value-4'}, - value=4), - helpers.create_metric(name=name, timestamp=start_timestamp + 2000, - dimensions={'key1': 'value-2', - 'key2': 'value-2'}, - value=5), - helpers.create_metric(name=name, timestamp=start_timestamp + 2500, - dimensions={'key1': 'value-3', - 'key2': 'value-3'}, - value=6), - helpers.create_metric(name=name, timestamp=start_timestamp + 3000, - dimensions={'key1': 'value-4', - 'key2': 'value-4'}, - value=7), - helpers.create_metric(name=name, timestamp=start_timestamp + 3500, - dimensions={'key1': 'value-4', - 'key2': 'value-4'}, - value=8) + value=4) ] self.monasca_client.create_metrics(metric) - - for timer in xrange(WAIT_TIME): - query_parms = '?name=' + name + query_parms = '?name=' + name + for i in xrange(constants.MAX_RETRIES): resp, response_body = self.monasca_client.list_metrics(query_parms) self.assertEqual(200, resp.status) elements = response_body['elements'] if elements: break else: - time.sleep(1) - if timer == WAIT_TIME - 1: - skip_msg = ("Skipped test_list_statistics_with_offset_limit: " - "timeout on waiting for metrics: 4 elements are " - "needed. Current number of elements = {}").\ - format(len(elements)) - raise self.skipException(skip_msg) + time.sleep(constants.RETRY_WAIT_SECS) + self._check_timeout(i, constants.MAX_RETRIES, elements, 4) - start_time = timeutils.iso8601_from_timestamp( - start_timestamp / 1000) + start_time = helpers.timestamp_to_iso(start_timestamp) end_timestamp = start_timestamp + 4000 - end_time = timeutils.iso8601_from_timestamp(end_timestamp / 1000) - query_parms = '?name=' + name + '&merge_metrics=true&statistics=avg,' \ - 'max,min,sum,count&start_time=' + str(start_time) + \ - '&end_time=' + str(end_time) + '&period=1' + end_time = helpers.timestamp_to_iso(end_timestamp) + query_parms = '?name=' + name + '&merge_metrics=true&statistics=avg' \ + + '&start_time=' + str(start_time) + '&end_time=' + \ + str(end_time) + '&period=1' resp, body = self.monasca_client.list_statistics(query_parms) self.assertEqual(200, resp.status) elements = body['elements'][0]['statistics'] first_element = elements[0] last_element = elements[3] - query_parms = '?name=' + name + '&merge_metrics=true&statistics=avg,' \ - 'max,min,sum,count&start_time=' + str(start_time) + \ - '&end_time=' + str(end_time) + '&period=1' + '&limit=4' + query_parms = '?name=' + name + '&merge_metrics=true&statistics=avg'\ + + '&start_time=' + str(start_time) + '&end_time=' + \ + str(end_time) + '&period=1' + '&limit=4' resp, response_body = self.monasca_client.list_statistics( query_parms) self.assertEqual(200, resp.status) @@ -252,11 +236,10 @@ class TestStatistics(base.BaseMonascaTest): offset = timeutils.iso8601_from_timestamp( offset_timestamp / 1000) query_parms = '?name=' + name + '&merge_metrics=true' + \ - '&statistics=avg,max,min,sum,' \ - 'count&start_time=' + str(start_time) + \ - '&end_time=' + str(end_time) + \ - '&period=1' + '&limit=' + str(limit) + \ - '&offset=' + str(offset) + '&statistics=avg' + '&start_time=' + \ + str(start_time) + '&end_time=' + \ + str(end_time) + '&period=1' + '&limit=' + \ + str(limit) + '&offset=' + str(offset) resp, response_body = self.monasca_client.list_statistics( query_parms) self.assertEqual(200, resp.status) @@ -272,64 +255,57 @@ class TestStatistics(base.BaseMonascaTest): self.assertEqual(last_element, next_element) break - @test.attr(type="gate") - def test_list_statistics_with_merge_metrics(self): - start_time = timeutils.iso8601_from_timestamp( - self._start_timestamp / 1000) - end_time = timeutils.iso8601_from_timestamp(self._end_timestamp / 1000) - query_parms = '?name=name-1&merge_metrics=true&statistics=avg&' \ - 'merge_metrics=true&start_time=' + str(start_time) + \ - '&end_time=' + str(end_time) - resp, response_body = self.monasca_client.list_statistics( - query_parms) - self.assertEqual(200, resp.status) - @test.attr(type="gate") @test.attr(type=['negative']) def test_list_statistics_with_no_merge_metrics(self): - start_time = timeutils.\ - iso8601_from_timestamp(self._start_timestamp / 1000) - end_time = timeutils.\ - iso8601_from_timestamp(self._end_timestamp / 1000) - query_parms = '?name=name-1&merge_metrics=false&' \ - 'statistics=avg,min,max&start_time=' + str(start_time)\ - + '&end_time=' + str(end_time) - self.assertRaises(exceptions.Conflict, - self.monasca_client.list_statistics, query_parms) + key = data_utils.rand_name('key') + value = data_utils.rand_name('value') + metric3 = helpers.create_metric( + name=self._test_name, + dimensions={key: value}, + timestamp=self._start_timestamp + 2000) + self.monasca_client.create_metrics(metric3) + query_param = '?name=' + str(self._test_name) + '&start_time=' + \ + self._start_time_iso + '&end_time=' + helpers.\ + timestamp_to_iso(self._start_timestamp + 1000 * 4) + \ + '&merge_metrics=True' + + for i in xrange(constants.MAX_RETRIES): + resp, response_body = self.monasca_client.\ + list_measurements(query_param) + elements = response_body['elements'] + for element in elements: + if str(element['name']) == self._test_name and len( + element['measurements']) == 3: + end_time_iso = helpers.timestamp_to_iso( + self._start_timestamp + 1000 * 4) + query_parms = '?name=' + str(self._test_name) + \ + '&statistics=avg' + '&start_time=' + \ + str(self._start_time_iso) + '&end_time=' +\ + str(end_time_iso) + '&period=100000' + self.assertRaises(exceptions.Conflict, + self.monasca_client.list_statistics, + query_parms) + return + time.sleep(constants.RETRY_WAIT_SECS) + self._check_timeout(i, constants.MAX_RETRIES, elements, 3) @test.attr(type="gate") @test.attr(type=['negative']) def test_list_statistics_with_name_exceeds_max_length(self): long_name = "x" * (constants.MAX_LIST_STATISTICS_NAME_LENGTH + 1) - start_time = timeutils.iso8601_from_timestamp(self._start_timestamp - / 1000) - end_time = timeutils.iso8601_from_timestamp(self._end_timestamp / 1000) - query_parms = '?merge_metrics=true&name=' + str(long_name) + \ - '&start_time=' + str(start_time) + '&end_time=' + str( - end_time) + query_parms = '?name=' + str(long_name) + '&merge_metrics=true' + \ + '&start_time=' + str(self._start_time_iso) + \ + '&end_time=' + str(self._end_time_iso) self.assertRaises(exceptions.UnprocessableEntity, self.monasca_client.list_statistics, query_parms) - @test.attr(type="gate") - def test_list_statistics_with_more_than_one_statistics(self): - start_time = timeutils.\ - iso8601_from_timestamp(self._start_timestamp / 1000) - end_time = timeutils.iso8601_from_timestamp(self._end_timestamp / 1000) - query_parms = '?name=name-1&merge_metrics=true&' \ - 'statistics=avg,min,max&start_time=' + str(start_time)\ - + '&end_time=' + str(end_time) - resp, response_body = self.monasca_client.list_statistics( - query_parms) - self.assertEqual(200, resp.status) - @test.attr(type="gate") def test_list_statistics_response_body_statistic_result_type(self): - start_time = timeutils.iso8601_from_timestamp(self._start_timestamp - / 1000) - end_time = timeutils.iso8601_from_timestamp(self._end_timestamp / 1000) - query_parms = '?name=name-1&merge_metrics=true&statistics=avg' \ - '&start_time=' + str(start_time) + '&end_time=' \ - + str(end_time) + query_parms = '?name=' + str(self._test_name) + '&period=100000' + \ + '&statistics=avg' + '&merge_metrics=true' + \ + '&start_time=' + str(self._start_time_iso) + \ + '&end_time=' + str(self._end_time_iso) resp, response_body = self.monasca_client.list_statistics( query_parms) self.assertEqual(200, resp.status) @@ -337,3 +313,41 @@ class TestStatistics(base.BaseMonascaTest): statistic = element['statistics'] statistic_result_type = type(statistic[0][1]) self.assertEqual(statistic_result_type, float) + + def _verify_statistics(self, statistics, num1, num2): + self.assertTrue(type(statistics) is list) + self.assertEqual(statistics[1], (num1 + num2) / 2) + self.assertEqual(statistics[2], min(num1, num2)) + self.assertEqual(statistics[3], max(num1, num2)) + self.assertEqual(statistics[4], num1 + num2) + self.assertEqual(statistics[5], 2) + + def _verify_element(self, element): + self.assertTrue(set(['id', 'name', 'dimensions', 'columns', + 'statistics']) == set(element)) + self.assertTrue(type(element['id']) is unicode) + self.assertTrue(element['id'] is not None) + self.assertTrue(type(element['name']) is unicode) + self.assertTrue(type(element['dimensions']) is dict) + self.assertEqual(len(element['dimensions']), 0) + self.assertTrue(type(element['columns']) is list) + self.assertTrue(type(element['statistics']) is list) + self.assertEqual(element['name'], self._test_name) + + def _verify_column(self, column, num_statistics_method): + self.assertTrue(type(column) is list) + self.assertEqual(len(column), num_statistics_method + 1) + self.assertEqual(column[0], 'timestamp') + self.assertEqual(column[1], 'avg') + self.assertEqual(column[2], 'min') + self.assertEqual(column[3], 'max') + self.assertEqual(column[4], 'sum') + self.assertEqual(column[5], 'count') + + def _check_timeout(self, timer, max_retries, elements, + expect_num_elements): + if timer == max_retries - 1: + error_msg = ("Failed: timeout on waiting for metrics: {} elements " + "are needed. Current number of elements = {}").\ + format(expect_num_elements, len(elements)) + raise self.fail(error_msg)