From 37418ced552ffa76286e8eea39a1ea7ea2a6b7d4 Mon Sep 17 00:00:00 2001 From: Joe Keen Date: Wed, 4 Nov 2015 17:08:16 -0700 Subject: [PATCH] Added type check to alarm definition schema Change-Id: I4df90a9cbd67ee95be80b061d494fae3bc6e1307 --- .../v2/common/schemas/alarm_definition_request_body_schema.py | 3 +++ 1 file changed, 3 insertions(+) diff --git a/monasca_api/v2/common/schemas/alarm_definition_request_body_schema.py b/monasca_api/v2/common/schemas/alarm_definition_request_body_schema.py index abf2f29f3..74b411820 100644 --- a/monasca_api/v2/common/schemas/alarm_definition_request_body_schema.py +++ b/monasca_api/v2/common/schemas/alarm_definition_request_body_schema.py @@ -34,6 +34,9 @@ def list_item_length(v): if not isinstance(v, list): raise Invalid('Not a list: {}'.format(type(v))) for i in v: + if not isinstance(i, (str, unicode)): + raise Invalid('list item <{}> -> {} not one of (str, unicode)' + .format(i, type(i))) if len(i) > MAX_ITEM_LENGTH: raise Invalid('length {} > {}'.format(len(i), MAX_ITEM_LENGTH))