Change assertTrue(isinstance()) by optimal assert
Some of tests use different method of assertTrue(isinstance(A, B)) or assertEqual(type(A), B). The correct way is to use assertIsInstance(A, B) provided by testtools Change-Id: Ia94ff8a08d298e5e90bfdefca00a9ff0efa31053
This commit is contained in:
parent
430d3bc762
commit
c008f8884f
@ -287,7 +287,7 @@ class RolesMiddlewareLogicTest(unittest.TestCase):
|
||||
result = instance.process_request(req=req)
|
||||
|
||||
self.assertIsNotNone(result)
|
||||
self.assertTrue(isinstance(result, response.Response))
|
||||
self.assertIsInstance(result, response.Response)
|
||||
|
||||
status = result.status_code
|
||||
json_body = result.json_body
|
||||
@ -317,7 +317,7 @@ class RolesMiddlewareLogicTest(unittest.TestCase):
|
||||
result = instance.process_request(req=req)
|
||||
|
||||
self.assertIsNotNone(result)
|
||||
self.assertTrue(isinstance(result, response.Response))
|
||||
self.assertIsInstance(result, response.Response)
|
||||
|
||||
status = result.status_code
|
||||
json_body = result.json_body
|
||||
|
Loading…
Reference in New Issue
Block a user