openstack/monasca-notification
Code Issues Proposed changes

Merge "Fix race condition in notification type inserts"

Browse Source
This commit is contained in:
Jenkins
2016-08-10 15:42:50 +00:00
committed by Gerrit Code Review
parent 18863c724f 9ee7f5c6fe
commit 2106901f11
1 changed files with 10 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
monasca_notification/common/repositories/mysql/mysql_repo.py
View File

@@ -108,6 +108,16 @@ class MysqlRepo(BaseRepo):
cur = self._mysql.cursor() cur = self._mysql.cursor()
cur.executemany(self._insert_notification_types_sql, notification_types) cur.executemany(self._insert_notification_types_sql, notification_types)
except pymysql.IntegrityError as ignoredException:
# If multiple instances of the notification engine tries to write the
# same content at the same time, only one of them will succeed and others will
# get duplicate primary key, integrity error. We can safely ignore this error.
# This may happen only during the first start when the tables are empty.
code, mesg = ignoredException.args
if code == pymysql.constants.ER.DUP_ENTRY:
log.debug("Notification type exists in DB. Ignoring the exception {}".format(mesg))
else:
raise exc.DatabaseException(ignoredException)
except pymysql.Error as e: except pymysql.Error as e:
self._mysql = None self._mysql = None
log.exception("Couldn't insert notification types %s", e) log.exception("Couldn't insert notification types %s", e)