openstack/monasca-notification
Code Issues Proposed changes

Set legacy_kafka_client_enabled = False on default

Browse Source 
We change the default value of kafka.legacy_kafka_client_enabled from
True to False. The use of new Confluent Kafka client is recommended.

Change-Id: Ie6a15474ebc1f04b8555ee44d413c19ee26a9227
Story: 2007924
Task: 40339
This commit is contained in:
Witek Bedyk 2020-07-14 15:37:42 +02:00
parent 7faa2184cd
commit f9978670b8
2 changed files with 7 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
monasca_notification/conf/kafka.py
View File

@ -63,7 +63,7 @@ kafka_opts = [
help='Maximum lag for topic that is acceptable by ' help='Maximum lag for topic that is acceptable by '
'the monasca-notification. Notifications that are older ' 'the monasca-notification. Notifications that are older '
'than this offset are skipped.'), 'than this offset are skipped.'),
cfg.BoolOpt(name='legacy_kafka_client_enabled', default=True, cfg.BoolOpt(name='legacy_kafka_client_enabled', default=False,
required=True, advanced=True, required=True, advanced=True,
help='Enable legacy Kafka client. When set old version of ' help='Enable legacy Kafka client. When set old version of '
'kafka-python library is used. Message format version ' 'kafka-python library is used. Message format version '

6
releasenotes/notes/disable-legacy-kafka-client-50fda1487ddda782.yaml Normal file
View File

@ -0,0 +1,6 @@
---
upgrade:
- |
The default value of ``kafka.legacy_kafka_client_enabled`` has changed
from ``True`` to ``False``. The use of new Confluent Kafka client is
recommended.