openstack/monasca-persister
Code Issues Proposed changes

Fix message parsing when link or lifecycle state is None

Browse Source 
Change-Id: Ibd826ca4b2ddf2c1ae586b1168cbe642a1028609
This commit is contained in:
Ryan Brandt 2016-02-09 14:45:48 -07:00
parent b544aa5ba8
commit cb3ec75b80
1 changed files with 10 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
monasca_persister/persister.py
View File

@ -633,10 +633,18 @@ def parse_alarm_state_hist_message(message):
old_state = alarm_transitioned['oldState']
LOG.debug('old state: %s', old_state)
link = alarm_transitioned['link'] if 'link' in alarm_transitioned else ""
# Key may not exist or value may be none, convert both to ""
if 'link' in alarm_transitioned and alarm_transitioned['link'] is not None:
link = alarm_transitioned['link']
else:
link = ""
LOG.debug('link: %s', link)
lifecycle_state = alarm_transitioned['lifecycleState'] if 'lifecycleState' in alarm_transitioned else ""
# Key may not exist or value may be none, convert both to ""
if 'lifecycleState' in alarm_transitioned and alarm_transitioned['lifecycleState'] is not None:
lifecycle_state = alarm_transitioned['lifecycleState']
else:
lifecycle_state = ""
LOG.debug('lifecycle_state: %s', lifecycle_state)
state_change_reason = alarm_transitioned[