Update patch set 9

Patch Set 9: Code-Review-1

(13 comments)

Patch-set: 9
Label: Code-Review=-1
This commit is contained in:
Gerrit User 16253 2018-08-02 09:37:06 +00:00 committed by Gerrit Code Review
parent b1f0ca7d91
commit 2a3ddd5a6e

View File

@ -0,0 +1,297 @@
{
"comments": [
{
"key": {
"uuid": "5f7c97a3_c82108b4",
"filename": "specs/rocky/approved/monasca-events-publishing.rst",
"patchSetId": 9
},
"lineNbr": 0,
"author": {
"id": 16253
},
"writtenOn": "2018-08-02T09:37:06Z",
"side": 1,
"message": "Authentication?",
"revId": "69d06bb96e9d6a2da0074c5766a6d13da585200e",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "5f7c97a3_c8d7c8bc",
"filename": "specs/rocky/approved/monasca-events-publishing.rst",
"patchSetId": 9
},
"lineNbr": 32,
"author": {
"id": 16253
},
"writtenOn": "2018-08-02T09:37:06Z",
"side": 1,
"message": "Do Ceilometer samples correspond to Monasca metrics? Shouldn\u0027t that be mentioned?",
"range": {
"startLine": 32,
"startChar": 84,
"endLine": 32,
"endChar": 91
},
"revId": "69d06bb96e9d6a2da0074c5766a6d13da585200e",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "5f7c97a3_6848f488",
"filename": "specs/rocky/approved/monasca-events-publishing.rst",
"patchSetId": 9
},
"lineNbr": 35,
"author": {
"id": 16253
},
"writtenOn": "2018-08-02T09:37:06Z",
"side": 1,
"message": "This \"event publisher\"...Is it just an agent/collector who sends the original events to Monasca? Or is it at the end of the \"Ceilometer data processing pipeline\" and the events are \"modified/unified\" and sent to Monasca?",
"range": {
"startLine": 35,
"startChar": 12,
"endLine": 35,
"endChar": 27
},
"revId": "69d06bb96e9d6a2da0074c5766a6d13da585200e",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "5f7c97a3_2b20b64a",
"filename": "specs/rocky/approved/monasca-events-publishing.rst",
"patchSetId": 9
},
"lineNbr": 286,
"author": {
"id": 16253
},
"writtenOn": "2018-08-02T09:37:06Z",
"side": 1,
"message": "Seems the \"Custom Monasca Ceilometer event publisher\" requires the whole Ceilometer pipeline...Isn\u0027t that a big overhead in terms of HW resources? What about HA, scalability...?",
"range": {
"startLine": 286,
"startChar": 20,
"endLine": 286,
"endChar": 61
},
"revId": "69d06bb96e9d6a2da0074c5766a6d13da585200e",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "5f7c97a3_8bbb0ae2",
"filename": "specs/rocky/approved/monasca-events-publishing.rst",
"patchSetId": 9
},
"lineNbr": 287,
"author": {
"id": 16253
},
"writtenOn": "2018-08-02T09:37:06Z",
"side": 1,
"message": "Can you please add a reference/link to the Monasca Event format?",
"range": {
"startLine": 287,
"startChar": 30,
"endLine": 287,
"endChar": 50
},
"revId": "69d06bb96e9d6a2da0074c5766a6d13da585200e",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "5f7c97a3_6b022e74",
"filename": "specs/rocky/approved/monasca-events-publishing.rst",
"patchSetId": 9
},
"lineNbr": 354,
"author": {
"id": 16253
},
"writtenOn": "2018-08-02T09:37:06Z",
"side": 1,
"message": "publisher_id",
"range": {
"startLine": 354,
"startChar": 12,
"endLine": 354,
"endChar": 23
},
"revId": "69d06bb96e9d6a2da0074c5766a6d13da585200e",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "5f7c97a3_2ba3d6b1",
"filename": "specs/rocky/approved/monasca-events-publishing.rst",
"patchSetId": 9
},
"lineNbr": 359,
"author": {
"id": 16253
},
"writtenOn": "2018-08-02T09:37:06Z",
"side": 1,
"message": "yes?",
"range": {
"startLine": 359,
"startChar": 55,
"endLine": 359,
"endChar": 57
},
"revId": "69d06bb96e9d6a2da0074c5766a6d13da585200e",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "5f7c97a3_ab960649",
"filename": "specs/rocky/approved/monasca-events-publishing.rst",
"patchSetId": 9
},
"lineNbr": 362,
"author": {
"id": 16253
},
"writtenOn": "2018-08-02T09:37:06Z",
"side": 1,
"message": "I\u0027m confused...Ceilometer events are mapped to Monasca events...do we need this the other way round, too?",
"range": {
"startLine": 362,
"startChar": 23,
"endLine": 362,
"endChar": 83
},
"revId": "69d06bb96e9d6a2da0074c5766a6d13da585200e",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "5f7c97a3_cb426293",
"filename": "specs/rocky/approved/monasca-events-publishing.rst",
"patchSetId": 9
},
"lineNbr": 367,
"author": {
"id": 16253
},
"writtenOn": "2018-08-02T09:37:06Z",
"side": 1,
"message": "I can not find the \"project_id\" in the Example Monasca Event...probably you mean the \"tenant_id\"...\n\nWill this tenant_id and user_id be used for the Keystone Authentication?",
"range": {
"startLine": 367,
"startChar": 34,
"endLine": 367,
"endChar": 44
},
"revId": "69d06bb96e9d6a2da0074c5766a6d13da585200e",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "5f7c97a3_6bec6e91",
"filename": "specs/rocky/approved/monasca-events-publishing.rst",
"patchSetId": 9
},
"lineNbr": 385,
"author": {
"id": 16253
},
"writtenOn": "2018-08-02T09:37:06Z",
"side": 1,
"message": "You mean implement a \"new\" event-agent...collect events from RabbitMQ...?",
"range": {
"startLine": 384,
"startChar": 3,
"endLine": 385,
"endChar": 44
},
"revId": "69d06bb96e9d6a2da0074c5766a6d13da585200e",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "5f7c97a3_ab512633",
"filename": "specs/rocky/approved/monasca-events-publishing.rst",
"patchSetId": 9
},
"lineNbr": 403,
"author": {
"id": 16253
},
"writtenOn": "2018-08-02T09:37:06Z",
"side": 1,
"message": "Why do we have to be aligned with the Ceilometer Event data format?\nThese fields contain important information...we should keep it.\nDimensions are a Monasca \"concept\" we should keep that...not only for (easy) filtering",
"range": {
"startLine": 402,
"startChar": 3,
"endLine": 403,
"endChar": 45
},
"revId": "69d06bb96e9d6a2da0074c5766a6d13da585200e",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "5f7c97a3_1e4f3a69",
"filename": "specs/rocky/approved/monasca-events-publishing.rst",
"patchSetId": 9
},
"lineNbr": 405,
"author": {
"id": 16253
},
"writtenOn": "2018-08-02T09:37:06Z",
"side": 1,
"message": "\"tenant_id\" and \"user_id\"...we will add these fields? Into the payload? Probably I missed some important information?",
"range": {
"startLine": 405,
"startChar": 3,
"endLine": 405,
"endChar": 78
},
"revId": "69d06bb96e9d6a2da0074c5766a6d13da585200e",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "5f7c97a3_de9302a3",
"filename": "specs/rocky/approved/monasca-events-publishing.rst",
"patchSetId": 9
},
"lineNbr": 425,
"author": {
"id": 16253
},
"writtenOn": "2018-08-02T09:37:06Z",
"side": 1,
"message": "probably additional HW resources are needed? Ceilometer pipeline...",
"range": {
"startLine": 425,
"startChar": 0,
"endLine": 425,
"endChar": 18
},
"revId": "69d06bb96e9d6a2da0074c5766a6d13da585200e",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
}
]
}