From 3d953a8d8b6ea1544a080c9a47763830c299e3f7 Mon Sep 17 00:00:00 2001 From: Gerrit User 11580 <11580@4a232e18-c5a9-48ee-94c0-e04e7cca6543> Date: Tue, 7 Aug 2018 17:35:51 +0000 Subject: [PATCH] Update patch set 9 Patch Set 9: (1 comment) Patch-set: 9 Label: Verified=0 --- 69d06bb96e9d6a2da0074c5766a6d13da585200e | 24 ++++++++++++++++++++++++ 1 file changed, 24 insertions(+) diff --git a/69d06bb96e9d6a2da0074c5766a6d13da585200e b/69d06bb96e9d6a2da0074c5766a6d13da585200e index b0d4dda..9f4e856 100644 --- a/69d06bb96e9d6a2da0074c5766a6d13da585200e +++ b/69d06bb96e9d6a2da0074c5766a6d13da585200e @@ -631,6 +631,30 @@ "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543", "unresolved": false }, + { + "key": { + "uuid": "3f79a3b5_94568b29", + "filename": "specs/rocky/approved/monasca-events-publishing.rst", + "patchSetId": 9 + }, + "lineNbr": 403, + "author": { + "id": 11580 + }, + "writtenOn": "2018-08-07T17:35:51Z", + "side": 1, + "message": "generic way (like grepping for nova) might be hard to get right.\n\nWe could have leveraged Ceilometer event definition config file to say add trait which is a literal service name \u0027compute\u0027 to all \u0027compute.instance.*\u0027 events, but most likely that wont work because its likely the code expects it to be valid JSON dotted notation string, might be worth seeing if we can add ability to add (inject) a literal string as a trait to Ceilometer event.", + "parentUuid": "3f79a3b5_53dd7012", + "range": { + "startLine": 402, + "startChar": 3, + "endLine": 403, + "endChar": 45 + }, + "revId": "69d06bb96e9d6a2da0074c5766a6d13da585200e", + "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543", + "unresolved": false + }, { "key": { "uuid": "5f7c97a3_1e4f3a69",