From 46c8b607743df629bb1a7e844e7bfcc9e2c22fec Mon Sep 17 00:00:00 2001 From: Gerrit User 11580 <11580@4a232e18-c5a9-48ee-94c0-e04e7cca6543> Date: Fri, 3 Aug 2018 19:13:03 +0000 Subject: [PATCH] Update patch set 9 Patch Set 9: (2 comments) Patch-set: 9 --- 69d06bb96e9d6a2da0074c5766a6d13da585200e | 42 ++++++++++++++++++++++++ 1 file changed, 42 insertions(+) diff --git a/69d06bb96e9d6a2da0074c5766a6d13da585200e b/69d06bb96e9d6a2da0074c5766a6d13da585200e index 6838bb8..f45281f 100644 --- a/69d06bb96e9d6a2da0074c5766a6d13da585200e +++ b/69d06bb96e9d6a2da0074c5766a6d13da585200e @@ -53,6 +53,24 @@ "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543", "unresolved": false }, + { + "key": { + "uuid": "3f79a3b5_5a613539", + "filename": "specs/rocky/approved/monasca-events-publishing.rst", + "patchSetId": 9 + }, + "lineNbr": 0, + "author": { + "id": 11580 + }, + "writtenOn": "2018-08-03T19:13:03Z", + "side": 1, + "message": "Thx! Monasca Events API doesnt have querying capability yet, I will add paragraph about cross tenant monitoring in the spec since its important.", + "parentUuid": "5f7c97a3_9db6d58c", + "revId": "69d06bb96e9d6a2da0074c5766a6d13da585200e", + "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543", + "unresolved": false + }, { "key": { "uuid": "5f7c97a3_c8d7c8bc", @@ -547,6 +565,30 @@ "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543", "unresolved": false }, + { + "key": { + "uuid": "3f79a3b5_ba4ba9ae", + "filename": "specs/rocky/approved/monasca-events-publishing.rst", + "patchSetId": 9 + }, + "lineNbr": 403, + "author": { + "id": 11580 + }, + "writtenOn": "2018-08-03T19:13:03Z", + "side": 1, + "message": "I agree \"hostname\" is important. Lets add this back in again. We can leverage ability to define \"trait\" via a config file to always \"hostname\".\n\nRegarding \"service\", do you think we should add a mapping file, something that maps event name to a service and maintain such a file?", + "parentUuid": "5f7c97a3_3836afe1", + "range": { + "startLine": 402, + "startChar": 3, + "endLine": 403, + "endChar": 45 + }, + "revId": "69d06bb96e9d6a2da0074c5766a6d13da585200e", + "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543", + "unresolved": false + }, { "key": { "uuid": "5f7c97a3_1e4f3a69",