From 69edb2cea20b6257f7d06e26ec54f409706655e0 Mon Sep 17 00:00:00 2001 From: Gerrit User 16253 <16253@4a232e18-c5a9-48ee-94c0-e04e7cca6543> Date: Wed, 8 Aug 2018 12:00:30 +0000 Subject: [PATCH] Update patch set 14 Patch Set 14: (9 comments) Patch-set: 14 Reviewer: Gerrit User 16253 <16253@4a232e18-c5a9-48ee-94c0-e04e7cca6543> Label: Verified=0 --- 449c9eed84d05260797b438b8449bb512beef619 | 188 +++++++++++++++++++++++ 1 file changed, 188 insertions(+) create mode 100644 449c9eed84d05260797b438b8449bb512beef619 diff --git a/449c9eed84d05260797b438b8449bb512beef619 b/449c9eed84d05260797b438b8449bb512beef619 new file mode 100644 index 0000000..c94653e --- /dev/null +++ b/449c9eed84d05260797b438b8449bb512beef619 @@ -0,0 +1,188 @@ +{ + "comments": [ + { + "key": { + "uuid": "3f79a3b5_1236f9e7", + "filename": "specs/rocky/approved/monasca-events-publishing.rst", + "patchSetId": 14 + }, + "lineNbr": 17, + "author": { + "id": 16253 + }, + "writtenOn": "2018-08-08T12:00:30Z", + "side": 1, + "message": "What is the difference of Openstack notifications and Openstack events? (A definition or a link to it would be fine).\nDo we really have to restrict the notification/events to OpenStack notification/events?", + "range": { + "startLine": 16, + "startChar": 76, + "endLine": 17, + "endChar": 28 + }, + "revId": "449c9eed84d05260797b438b8449bb512beef619", + "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543", + "unresolved": false + }, + { + "key": { + "uuid": "3f79a3b5_d77953fc", + "filename": "specs/rocky/approved/monasca-events-publishing.rst", + "patchSetId": 14 + }, + "lineNbr": 44, + "author": { + "id": 16253 + }, + "writtenOn": "2018-08-08T12:00:30Z", + "side": 1, + "message": "?", + "range": { + "startLine": 44, + "startChar": 11, + "endLine": 44, + "endChar": 21 + }, + "revId": "449c9eed84d05260797b438b8449bb512beef619", + "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543", + "unresolved": false + }, + { + "key": { + "uuid": "3f79a3b5_775b9f53", + "filename": "specs/rocky/approved/monasca-events-publishing.rst", + "patchSetId": 14 + }, + "lineNbr": 47, + "author": { + "id": 16253 + }, + "writtenOn": "2018-08-08T12:00:30Z", + "side": 1, + "message": "means we have one Ceilometer Notification Agent \"service\", on a \"central\" place...the control node(s), one Ceilometer Notification Agent \"service\" instance is installed per control node to achieve HA, correct?", + "range": { + "startLine": 46, + "startChar": 46, + "endLine": 47, + "endChar": 60 + }, + "revId": "449c9eed84d05260797b438b8449bb512beef619", + "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543", + "unresolved": false + }, + { + "key": { + "uuid": "3f79a3b5_12b9192d", + "filename": "specs/rocky/approved/monasca-events-publishing.rst", + "patchSetId": 14 + }, + "lineNbr": 69, + "author": { + "id": 16253 + }, + "writtenOn": "2018-08-08T12:00:30Z", + "side": 1, + "message": "why we cannot use this token for the Authorization at the Monasca metric and event API?", + "range": { + "startLine": 69, + "startChar": 12, + "endLine": 69, + "endChar": 70 + }, + "revId": "449c9eed84d05260797b438b8449bb512beef619", + "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543", + "unresolved": false + }, + { + "key": { + "uuid": "3f79a3b5_72d88d7e", + "filename": "specs/rocky/approved/monasca-events-publishing.rst", + "patchSetId": 14 + }, + "lineNbr": 188, + "author": { + "id": 16253 + }, + "writtenOn": "2018-08-08T12:00:30Z", + "side": 1, + "message": "what about timestamp? It is important, isn\u0027t it?", + "range": { + "startLine": 185, + "startChar": 3, + "endLine": 188, + "endChar": 53 + }, + "revId": "449c9eed84d05260797b438b8449bb512beef619", + "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543", + "unresolved": false + }, + { + "key": { + "uuid": "3f79a3b5_12c6f949", + "filename": "specs/rocky/approved/monasca-events-publishing.rst", + "patchSetId": 14 + }, + "lineNbr": 468, + "author": { + "id": 16253 + }, + "writtenOn": "2018-08-08T12:00:30Z", + "side": 1, + "message": "Just to make sure:\nFor sending the events to Monasca the OpenStack admin credentials are used for Authorization. Monasca will store all these events in the admin project. Only member of the admin project have read access to these events.\n\"tenant_id\" available in the payload (if different to the OpenStack admin project) doesn\u0027t change that behavior...", + "range": { + "startLine": 458, + "startChar": 3, + "endLine": 468, + "endChar": 89 + }, + "revId": "449c9eed84d05260797b438b8449bb512beef619", + "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543", + "unresolved": false + }, + { + "key": { + "uuid": "3f79a3b5_7223ad06", + "filename": "specs/rocky/approved/monasca-events-publishing.rst", + "patchSetId": 14 + }, + "lineNbr": 484, + "author": { + "id": 16253 + }, + "writtenOn": "2018-08-08T12:00:30Z", + "side": 1, + "message": "pros and cons?", + "range": { + "startLine": 484, + "startChar": 0, + "endLine": 484, + "endChar": 12 + }, + "revId": "449c9eed84d05260797b438b8449bb512beef619", + "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543", + "unresolved": false + }, + { + "key": { + "uuid": "3f79a3b5_52d1d1fa", + "filename": "specs/rocky/approved/monasca-events-publishing.rst", + "patchSetId": 14 + }, + "lineNbr": 488, + "author": { + "id": 16253 + }, + "writtenOn": "2018-08-08T12:00:30Z", + "side": 1, + "message": "...to RabbitMQ (\"notification\" topic) and...", + "range": { + "startLine": 487, + "startChar": 83, + "endLine": 488, + "endChar": 8 + }, + "revId": "449c9eed84d05260797b438b8449bb512beef619", + "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543", + "unresolved": false + } + ] +} \ No newline at end of file