openstack
/
monasca-specs
Code Issues Proposed changes

Update patch set 4 

Patch Set 4:

(4 comments)

Patch-set: 4
This commit is contained in:
Gerrit User 11580 2018-07-19 18:47:34 +00:00 committed by Gerrit Code Review
parent 3240f96099
commit fed534fc32
1 changed files with 78 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

78
5398822ab09fad6a772b74823ab3c447e32f7177
View File

@ -17,6 +17,24 @@
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "5f7c97a3_75655248",
"filename": "specs/rocky/approved/monasca-events-publishing.rst",
"patchSetId": 4
},
"lineNbr": 177,
"author": {
"id": 11580
},
"writtenOn": "2018-07-19T18:47:34Z",
"side": 1,
"message": "good question we will have to find it out if it has any adverse impact on sample publisher. \nThough in case of samples, monasca sample publisher definitely does not submit the raw payload, so it must be getting dropped.\n\nAlso added to temp Questions/TODO here, so we keep track of this",
"parentUuid": "5f7c97a3_3c06f5ce",
"revId": "5398822ab09fad6a772b74823ab3c447e32f7177",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "5f7c97a3_dcafc19a",
@ -40,6 +58,30 @@
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "5f7c97a3_901b5c6d",
"filename": "specs/rocky/approved/monasca-events-publishing.rst",
"patchSetId": 4
},
"lineNbr": 246,
"author": {
"id": 11580
},
"writtenOn": "2018-07-19T18:47:34Z",
"side": 1,
"message": "Fixed",
"parentUuid": "5f7c97a3_dcafc19a",
"range": {
"startLine": 246,
"startChar": 44,
"endLine": 246,
"endChar": 45
},
"revId": "5398822ab09fad6a772b74823ab3c447e32f7177",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "5f7c97a3_7cbeadce",
@ -57,6 +99,24 @@
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "5f7c97a3_b5420a66",
"filename": "specs/rocky/approved/monasca-events-publishing.rst",
"patchSetId": 4
},
"lineNbr": 247,
"author": {
"id": 11580
},
"writtenOn": "2018-07-19T18:47:34Z",
"side": 1,
"message": "Done. Added a line for Panko (we can add more to it though)",
"parentUuid": "5f7c97a3_7cbeadce",
"revId": "5398822ab09fad6a772b74823ab3c447e32f7177",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "5f7c97a3_1c9f7965",
@ -73,6 +133,24 @@
"revId": "5398822ab09fad6a772b74823ab3c447e32f7177",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "5f7c97a3_f0ff30fd",
"filename": "specs/rocky/approved/monasca-events-publishing.rst",
"patchSetId": 4
},
"lineNbr": 257,
"author": {
"id": 11580
},
"writtenOn": "2018-07-19T18:47:34Z",
"side": 1,
"message": "Added to temp Questions/TODO here",
"parentUuid": "5f7c97a3_1c9f7965",
"revId": "5398822ab09fad6a772b74823ab3c447e32f7177",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
}
]
}