openstack
/
monasca-statsd
Code Issues Proposed changes

Clean up counter.py 

Extract duplicate code.

Change-Id: I145eec64cf3d5c508e8b37a4b78e78bd95a8137c
This commit is contained in:
Laszlo Hegedus 2016-08-17 14:34:18 +02:00 committed by Artur Basiak
parent 8c4c92a852
commit 13c7e0880f
1 changed files with 5 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
monascastatsd/counter.py
View File

@ -56,11 +56,7 @@ class Counter(metricbase.MetricBase):
>>> monascastatsd.increment()
>>> monascastatsd.increment(12)
"""
self._connection.report(metric=self._name,
metric_type='c',
value=value,
dimensions=self.update_dimensions(dimensions),
sample_rate=sample_rate)
self._report_change(dimensions, sample_rate, value)
def decrement(self, value=1, dimensions=None, sample_rate=1):
"""Decrement a counter, optionally setting a value, dimensions and a
@ -70,9 +66,12 @@ class Counter(metricbase.MetricBase):
>>> monascastatsd.decrement()
>>> monascastatsd.decrement(2)
"""
self._report_change(dimensions, sample_rate, -value)
def _report_change(self, dimensions, sample_rate, value):
self._connection.report(metric=self._name,
metric_type='c',
value=-value,
value=value,
dimensions=self.update_dimensions(dimensions),
sample_rate=sample_rate)