openstack
/
monasca-tempest-plugin
Code Issues Proposed changes

Change assertTrue(isinstance()) by optimal assert 

Some of tests use different method of
assertTrue(isinstance(A, B)) or assertEqual(type(A), B).
The correct way is to use assertIsInstance(A, B) provided
by testtools

Change-Id: Ic6be6e291c8afb125d12ec94df81d0f338495001
This commit is contained in:
gecong1973 2016-09-30 15:41:08 +08:00 committed by gecong
parent fe59447db7
commit 70c3715335
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
monasca_tempest_tests/tests/api/test_alarm_state_history_multiple_transitions.py
View File

@ -96,7 +96,7 @@ class TestAlarmStateHistoryMultipleTransitions(base.BaseMonascaTest):
set(response_body))
elements = response_body['elements']
links = response_body['links']
self.assertTrue(isinstance(links, list))
self.assertIsInstance(links, list)
link = links[0]
self.assertTrue(set(['rel', 'href']) ==
set(link))