openstack
/
monasca-tempest-plugin
Code Issues Proposed changes

Allow parentheses '()' in dimensions 

Update tempest tests to allow parentheses in dimensions.
Update documentation.

Change-Id: Idceed9a6cf2deff2c60bc865dc6a8fb2d0640412
Story: 2001385
Task: 5960
This commit is contained in:
Witold Bedyk 2017-12-05 15:24:51 +01:00
parent 526790e2f4
commit 9d2b047006
2 changed files with 5 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
monasca_tempest_tests/tests/api/constants.py
View File

@ -21,7 +21,8 @@ ALARM_DEFINITION_CREATION_WAIT = 1
MAX_METRIC_NAME_LENGTH = 255
MAX_DIMENSION_KEY_LENGTH = 255
MAX_DIMENSION_VALUE_LENGTH = 255
INVALID_CHARS = "<>={}(),\"\;&"
INVALID_DIMENSION_CHARS = "<>={},\"\;&"
INVALID_NAME_CHARS = INVALID_DIMENSION_CHARS + "()"
MAX_ALARM_DEFINITION_NAME_LENGTH = 255
MAX_ALARM_DEFINITION_DESCRIPTION_LENGTH = 255

6
monasca_tempest_tests/tests/api/test_metrics.py
View File

@ -318,7 +318,7 @@ class TestMetrics(base.BaseMonascaTest):
@decorators.attr(type='gate')
@decorators.attr(type=['negative'])
def test_create_metric_with_invalid_chars_in_name(self):
for invalid_char in constants.INVALID_CHARS:
for invalid_char in constants.INVALID_NAME_CHARS:
metric = helpers.create_metric(invalid_char)
self.assertRaises(exceptions.UnprocessableEntity,
self.monasca_client.create_metrics,
@ -327,12 +327,12 @@ class TestMetrics(base.BaseMonascaTest):
@decorators.attr(type='gate')
@decorators.attr(type=['negative'])
def test_create_metric_with_invalid_chars_in_dimensions(self):
for invalid_char in constants.INVALID_CHARS:
for invalid_char in constants.INVALID_DIMENSION_CHARS:
metric = helpers.create_metric('name-1', {'key-1': invalid_char})
self.assertRaises(exceptions.UnprocessableEntity,
self.monasca_client.create_metrics,
metric)
for invalid_char in constants.INVALID_CHARS:
for invalid_char in constants.INVALID_DIMENSION_CHARS:
metric = helpers.create_metric('name-1', {invalid_char: 'value-1'})
self.assertRaises(exceptions.UnprocessableEntity,
self.monasca_client.create_metrics,