openstack/monasca-thresh
Code Issues Proposed changes

Check that everything coming in on the EventSpout is Serializable before sending it out so the Spout doesn't die.

Browse Source
This commit is contained in:
Craig Bryant 2014-04-18 16:02:58 -06:00
parent 0aad1652d1
commit 6deb113700
1 changed files with 7 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/main/java/com/hpcloud/mon/infrastructure/thresholding/EventSpout.java
View File

@ -1,5 +1,6 @@
package com.hpcloud.mon.infrastructure.thresholding;
import java.io.Serializable;
import java.util.List;
import org.slf4j.Logger;
@ -35,7 +36,12 @@ public class EventSpout extends KafkaSpout {
List<List<?>> events = deserializer.deserialize(message);
if (events != null) {
for (final List<?> event : events) {
collector.emit(new Values(event.get(0)));
final Object eventToSend = event.get(0);
if (!(eventToSend instanceof Serializable)) {
LOG.error("Class {} is not Serializable: {}", eventToSend.getClass(), eventToSend);
continue;
}
collector.emit(new Values(eventToSend));
}
}
}