From 6584d93491ca4dddff3276feda5ac1e231dc97b1 Mon Sep 17 00:00:00 2001 From: Dirk Mueller Date: Sun, 4 Dec 2016 12:03:51 +0100 Subject: [PATCH] Remove imported but unused modules This allows us to enable F401 checks to ensure we're not regressing on this again. Change-Id: Ifd94bbaea72afe53daf9291554b68847e7bd34cf --- monitoring/alarmdefs/tables.py | 1 - monitoring/alarms/tables.py | 1 - monitoring/test/settings.py | 1 - tox.ini | 3 +-- 4 files changed, 1 insertion(+), 5 deletions(-) diff --git a/monitoring/alarmdefs/tables.py b/monitoring/alarmdefs/tables.py index 14510c9d..96502a89 100644 --- a/monitoring/alarmdefs/tables.py +++ b/monitoring/alarmdefs/tables.py @@ -13,7 +13,6 @@ # under the License. from django.core import urlresolvers -from django.http import HttpResponse from django.utils.translation import ugettext_lazy as _ # noqa from horizon import tables diff --git a/monitoring/alarms/tables.py b/monitoring/alarms/tables.py index 7042d2ef..5c45922e 100644 --- a/monitoring/alarms/tables.py +++ b/monitoring/alarms/tables.py @@ -15,7 +15,6 @@ import json -from django.conf import settings from django.core import urlresolvers from django.core.urlresolvers import reverse_lazy from django import template diff --git a/monitoring/test/settings.py b/monitoring/test/settings.py index 73d79a8d..ce594396 100644 --- a/monitoring/test/settings.py +++ b/monitoring/test/settings.py @@ -17,7 +17,6 @@ from django.conf import global_settings from django.utils.translation import ugettext_lazy as _ # noqa from horizon.test.settings import * # noqa -from horizon.utils import secret_key as secret_key_utils from openstack_dashboard.test.settings import * # noqa diff --git a/tox.ini b/tox.ini index 4ec7cc3a..e5eb5373 100644 --- a/tox.ini +++ b/tox.ini @@ -29,7 +29,6 @@ exclude = .venv,.git,.tox,dist,*lib/python*,*egg,build,panel_template,dash_templ # E127 continuation line over-indented for visual indent # E128 continuation line under-indented for visual indent # E501 line too long -# F401 imported but unused # F841 local variable is assigned to but never used # H102 Apache 2.0 license header not found # H238 old style class declaration, use new style @@ -40,4 +39,4 @@ exclude = .venv,.git,.tox,dist,*lib/python*,*egg,build,panel_template,dash_templ # H405 multi line docstring summary not separated with an empty line # H803 git commit title should not end with period (disabled on purpose, see bug #1236621) # H904 Wrap long lines in parentheses instead of a backslash -ignore = E127,E128,E501,F401,F841,H102,H238,H301,H305,H306,H307,H405,H803,H904 +ignore = E127,E128,E501,F841,H102,H238,H301,H305,H306,H307,H405,H803,H904