The repo is Python 3 now, so update hacking to version 3.0 which
supports Python 3.
Fix problems found by updated hacking version.
Remove hacking and friends from lower-constraints, they are not needed
for co-installing.
Change-Id: Ibef3bbaceb61612d678c542bc8c95da24a7e2c87
Django 1.11 ends its extended support in April 2020 (which is before
Ussuri release), so horizon drops Django 1.11 support in Ussuri.
tox envs for non-primary Django versions are no longer needed in tox.ini
as testing environments for non-primary Django versions are setup in
the zuul jobs now.
horizon>=17.1.0 is required to use Django 2.2. requirements.txt and
lower-constraints.txt are updated accordingly. for more info. please
refer [1].
Depends-On: https://review.opendev.org/#/c/700733/
[1] https://etherpad.openstack.org/p/Enable_Django22_support_in_Horizon_Plugin
Change-Id: I3cd4ad5c3fe590cb1522b2be1b2059d7c70b45cc
1. Update hacking version to latest
2. Update some urls to https
3. change the py35 to py36 since py35 is removed
Change-Id: I6de72299d865225ccb522dca8316a024eebe75fd
Using "python setup.py check -r -s" method of checking the package has
been deprecated with the new recommendation to build the sdist and
wheel, then running "twine check" against the output.
Luckily, there is already a job that covers this that only runs when the
README, setup.py, or setup.cfg files change, making running this in the
pep8 job redundant. This covered by the test-release-openstack-python3
that is defined in the publish-to-pypi-python3 template.
More details can be found in this mailing list post:
http://lists.openstack.org/pipermail/openstack-dev/2018-October/136136.html
Change-Id: I2398ba87d3511338d6092fd8dc3bccb434f49613
Signed-off-by: Sean McGinnis <sean.mcginnis@gmail.com>
We want to default to running all tox environments under python 3, so
set the basepython value in each environment.
We do not want to specify a minor version number, because we do not
want to have to update the file every time we upgrade python.
We do not want to set the override once in testenv, because that
breaks the more specific versions used in default environments like
py35 and py36.
Change-Id: I66b43b70c5ffd077e58e5a5f0e631bd3a0aa080a
* set the maximum line length to 100
* cleaned up the codes for pep8
* removed pep8 check ignores
Change-Id: I5d3e2f13117638b0a8af051b9faa64ce1a2dd04e
Signed-off-by: Amir Mofakhar <amofakhar@op5.com>
Create a tox environment for running the unit tests against the lower
bounds of the dependencies.
Create a lower-constraints.txt to be used to enforce the lower bounds
in those tests.
Add openstack-tox-lower-constraints job to the zuul configuration.
See http://lists.openstack.org/pipermail/openstack-dev/2018-March/128352.html
for more details.
monasca-ui specific changes:
- Unlike other projects, monasca-ui does not support python3 unit tests yet.
python2.7 is used as basepython. This should be updated to python3 later.
- Bump the the minimum version of python-monascaclient to 1.8.0
to pass test_client unit tests.
- nose-exclude needs to bumped to 0.5.0 to run all existing unit tests.
lower-constraints.txt is modified to match the latest horizon requirements
https://review.openstack.org/#/c/555491/:
- unit tests fails with Django 1.8. It passes with Django 1.11.
Horizon Rocky bumped the Django min version to >=1.11, so it makes sense
to bump the Django min version to 1.11.
- django-babel needs to bumped to 0.6.2 to support Django 1.11 and 2.0.
https://review.openstack.org/555402 allows us to bump lower requirements.
Co-Authored-By: Akihiro Motoki <amotoki@gmail.com>
Change-Id: Ifd967b598db259429cc83046ae88abaf3d50e081
Depends-On: https://review.openstack.org/555034
Depends-On: https://review.openstack.org/555402
Signed-off-by: Doug Hellmann <doug@doughellmann.com>
Signed-off-by: Akihiro Motoki <amotoki@gmail.com>
In order to make monasca-ui python3 compatible this
patch set:
- Add six to requirements.txt
- Add py35 to tox.ini
- Replace dict.iteritems() with six.iteritems(dict)
- Replace prit msg with print(msg)
- Replace unicode with six.text_type(msg)
- Replaces urlparse with six.moves.urllib
- Python 3 getting the keys() of a dict returns
a dict_keys object instead of a list
- python 2.x calling keys makes a copy of the key
that you can iterate over while modifying the dict.
This doesn't work in python 3.x because keys
returns an iterator instead of a list.
Another way is to use list to force a copy of the keys
to be made.
Story: 2000975
Task: 4129
Signed-off-by: Charles Short <zulcss@gmail.com>
Change-Id: Ibc644a734edceea0b36f2df2c73300d1e4db925f
Instead of using tox-install.sh, we can install horizon and neutron
now directly from pypi - or use the current branch in CI system using
tox-siblings.
Update tox.ini for this change and add horizon to requirements file.
Change-Id: Ife02518fce62083661bf06c0fb98e683c5c3d311
monasca-ui misses policies file to control the permissions
over actions executed from within Horizon plugin.
Extra:
* enabled running tests with configured policies
* removed unbounded policy sample file
Change-Id: I273f06332fa11a81ea8de2c13059dce9d160e90d
H305 and H307 hacking have been removed since hacking 0.10.
https://github.com/openstack-dev/hacking/blob/master/setup.cfg
test-requirements of monasca-ui require hacking >=0.12.0,<0.13.
So remove H305/H307 ignore statement
Closes-Bug: #1653596
Change-Id: I5090d1560254b31044e9ab4b72d44da0da6d785f
Adding constraints support to clients is slightly more complex than
services as the clients themselves are listed in upper-constraints.txt
which leads to errors that you can't install a specific version and a
constrained version.
This change adds constraints support by also adding a helper script to
edit the constraints to remove monasca-ui.
Change-Id: Ie2f4e3ed3e309b1176ec8bffa5466da25345fd64
H803 hacking have been removed since hacking 0.10.
https://github.com/openstack-dev/hacking/blob/master/setup.cfg
test-requirements of monasca-ui require hacking >=0.12.0,<0.13.
So remove H803 ignore statement
Closes-Bug: #1650850
Change-Id: Idcc6aa70feb1a3eadbb30e4d0e9187359365e3c2
Remove assignments to local variable that are not referenced later.
This allows to reenable the corresponding flake8 check to ensure that
we're not regressing later.
Depends-On: I3305775baaab15dca8d5e7e5cfc0932f94d4d153
Change-Id: Id55c8b55ab16fb826cefbaca73a91845c69fcc7b
Effectively all checks except for H236 were disabled on this project.
Switch from whitelist to blacklist approach, blacklist all checks that
are currently failing except for those pure-whitespace related ones. Fix
those.
Depends-On: I3305775baaab15dca8d5e7e5cfc0932f94d4d153
Change-Id: I054d3ef2b98ac6075628d290a93885ec8153c462
There is no this directory openstack/common which was used
to keep codes from oslo-incubator, we have retired oslo-incubator.
Removing openstack/commonfrom all OpenStack code in favor of the
Oslo libraries is a project wide goal for the Ocata release. So
don't use this directory any more. We should drop it for improving
searching efficiency.
Change-Id: Id8553d95bef7d2aa9f1f58b549a601bac1a30adf
Bring over the cleaning line from run_tests.sh for the pyc files to
all the tox runs.
This should eliminate the need to clean -x -i to kill pyc files in
your local directory to get tests to pass.
Change-Id: I415b7c9ed1c244fb08fc1ce9581e040656c65f09
Closes-Bug: #1368661
* add simple proxy for kibana requests
* organize settings in `local_settings.py`
* narrow down coverage to monitoring package
* fix requirements with stable versions
* upgrade Horizon
Change-Id: I618485e9b6fa11fe423c3b1b3ad5f8c02cc163b4
- Update horizon version
- Remove --upgrade option in venv installer and tox.ini
- Freeze oslo libs versions
Change-Id: I4b6697cba20699da59af8f9cc7440a669d9f0c6e