openstack/murano-dashboard
Code Issues Proposed changes

Treat hyphen as a special character during password validation

Browse Source 
Also added tests for password validation.

Change-Id: If30586c5e419871625e9d0c7389a14f40a559839
Closes-bug: #1589621
This commit is contained in:
Valerii Kovalchuk 2016-06-06 21:04:59 +03:00
parent 96677191a9
commit 551b73b84f
3 changed files with 43 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
muranodashboard/dynamic_ui/fields.py
View File

@ -209,7 +209,7 @@ class CharField(forms.CharField, CustomPropertiesField):
class PasswordField(CharField):
special_characters = '!@#$%^&*()_+|\/.,~?><:{}'
special_characters = '!@#$%^&*()_+|\/.,~?><:{}-'
password_re = re.compile('^.*(?=.*\d)(?=.*[a-z])(?=.*[A-Z])(?=.*[%s]).*$'
% special_characters)
has_clone = False

2
muranodashboard/static/muranodashboard/js/passwordfield.js
View File

@ -72,7 +72,7 @@ $(function() {
meetRequirements = false;
}
if (password.match(/[!@#$%^&*()_+|\/.,~?><:{}]+/) === null) {
if (password.match(/[!@#$%^&*()_+|\/.,~?><:{}-]+/) === null) {
text += " 1 special character";
meetRequirements = false;
}

41
muranodashboard/tests/test_fields.py
View File

@ -12,6 +12,8 @@
# License for the specific language governing permissions and limitations
# under the License.
from django.core import exceptions
from muranodashboard.dynamic_ui import fields
from openstack_dashboard.test import helpers
@ -82,3 +84,42 @@ class TestFlavorField(helpers.APITestCase):
initial_request = {}
f.update(initial_request, self.request)
self.assertEqual([], f.choices)
class TestPasswordField(helpers.TestCase):
def test_valid_input(self):
f = fields.PasswordField('')
for char in f.special_characters:
if char != '\\':
password = 'aA1111' + char
self.assertEqual(None, f.run_validators(password))
def test_short_input(self):
f = fields.PasswordField('')
password = 'aA@111'
self.assertRaises(exceptions.ValidationError, f.run_validators,
password)
def test_input_without_special_characters(self):
f = fields.PasswordField('')
password = 'aA11111'
self.assertRaises(exceptions.ValidationError, f.run_validators,
password)
def test_input_without_digits(self):
f = fields.PasswordField('')
password = 'aA@@@@@'
self.assertRaises(exceptions.ValidationError, f.run_validators,
password)
def test_input_without_lowecase(self):
f = fields.PasswordField('')
password = 'A1@@@@@'
self.assertRaises(exceptions.ValidationError, f.run_validators,
password)
def test_input_without_uppercase(self):
f = fields.PasswordField('')
password = 'a1@@@@@'
self.assertRaises(exceptions.ValidationError, f.run_validators,
password)