openstack
/
murano
Code Issues Proposed changes

Set access_policy for messaging's dispatcher 

oslo.messaging allow dispatcher to restrict endpoint methods since
5.11.0 in I42239e6c8a8be158ddf5c3b1773463b7dc93e881, set with
LegacyRPCAccessPolicy explicitly to ensure it's compatible and
fix FutureWarning like:

"The access_policy argument is changing its default value to <class
'oslo_messaging.rpc.dispatcher.DefaultRPCAccessPolicy'> in version '?',
please update the code to explicitly set None as the value:
access_policy defaults to LegacyRPCAccessPolicy which exposes private
methods. Explicitly set access_policy to DefaultRPCAccessPolicy or
ExplicitRPCAccessPolicy.

Change-Id: I60dfaa09113ebf2460126c968e5839f1b6a4bda9
This commit is contained in:
dineshbhor 2017-04-08 12:09:50 +05:30
parent 048be285c5
commit 705a81a216
2 changed files with 8 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
murano/common/engine.py
View File

@ -21,6 +21,7 @@ import eventlet.debug
from oslo_config import cfg
from oslo_log import log as logging
import oslo_messaging as messaging
from oslo_messaging.rpc import dispatcher
from oslo_messaging import target
from oslo_serialization import jsonutils
from oslo_service import service
@ -65,8 +66,10 @@ class EngineService(service.Service):
transport = messaging.get_notification_transport(CONF)
s_target = target.Target('murano', 'tasks', server=str(uuid.uuid4()))
access_policy = dispatcher.DefaultRPCAccessPolicy
self.server = messaging.get_rpc_server(
transport, s_target, endpoints, 'eventlet')
transport, s_target, endpoints, 'eventlet',
access_policy=access_policy)
self.server.start()
super(EngineService, self).start()

5
murano/common/server.py
View File

@ -17,6 +17,7 @@ import uuid
from oslo_config import cfg
from oslo_log import log as logging
import oslo_messaging as messaging
from oslo_messaging.rpc import dispatcher
from oslo_messaging import target
from oslo_service import service
from oslo_utils import timeutils
@ -242,7 +243,9 @@ class ApiService(Service):
transport = messaging.get_transport(CONF)
s_target = target.Target('murano', 'results', server=str(uuid.uuid4()))
access_policy = dispatcher.DefaultRPCAccessPolicy
self.server = messaging.get_rpc_server(
transport, s_target, endpoints, 'eventlet')
transport, s_target, endpoints, 'eventlet',
access_policy=access_policy)
self.server.start()
super(ApiService, self).start()