Increase unit test coverage for hacking checks
Implements bp: murano-unit-test-coverage Co-Authored-By: David Purcell <david.purcell@att.com> Co-Authored-By: Samantha Blanco <samantha.blanco@att.com> Co-Authored-By: Felipe Monteiro <felipe.monteiro@att.com> Change-Id: I1f71e17031cf1cac30b71e68657b380d07987b27
This commit is contained in:
parent
2d70b402c1
commit
a3a053d9ba
@ -83,3 +83,42 @@ class HackingTestCase(base.MuranoTestCase):
|
||||
|
||||
self.assertEqual(0, len(list(checks.no_mutable_default_args(
|
||||
"defined, undefined = [], {}"))))
|
||||
|
||||
def test_check_python3_no_iteritems(self):
|
||||
self.assertEqual(1, len(list(checks.check_python3_no_iteritems(
|
||||
"{'foo': 'bar'}.iteritems()"))))
|
||||
|
||||
self.assertEqual(0, len(list(checks.check_python3_no_iteritems(
|
||||
"six.iteritems({'foo': 'bar'}"))))
|
||||
|
||||
def test_check_python3_no_iterkeys(self):
|
||||
self.assertEqual(1, len(list(checks.check_python3_no_iterkeys(
|
||||
"{'foo': 'bar'}.iterkeys()"))))
|
||||
|
||||
self.assertEqual(0, len(list(checks.check_python3_no_iterkeys(
|
||||
"six.iterkeys({'foo': 'bar'}"))))
|
||||
|
||||
def test_check_python3_no_itervalues(self):
|
||||
self.assertEqual(1, len(list(checks.check_python3_no_itervalues(
|
||||
"{'foo': 'bar'}.itervalues()"))))
|
||||
|
||||
self.assertEqual(0, len(list(checks.check_python3_no_itervalues(
|
||||
"six.itervalues({'foo': 'bar'}"))))
|
||||
|
||||
def test_check_no_basestring(self):
|
||||
self.assertEqual(1, len(list(checks.check_no_basestring(
|
||||
"isinstance('foo', basestring)"))))
|
||||
|
||||
self.assertEqual(0, len(list(checks.check_no_basestring(
|
||||
"isinstance('foo', six.string_types)"))))
|
||||
|
||||
def test_factory(self):
|
||||
mock_register = mock.MagicMock()
|
||||
checks.factory(mock_register)
|
||||
expected = [
|
||||
mock.call(checks.no_mutable_default_args),
|
||||
mock.call(checks.check_python3_no_iteritems),
|
||||
mock.call(checks.check_python3_no_iterkeys),
|
||||
mock.call(checks.check_python3_no_itervalues),
|
||||
mock.call(checks.check_no_basestring)]
|
||||
mock_register.assert_has_calls(expected)
|
||||
|
Loading…
Reference in New Issue
Block a user