Some files in networking-l2gw/tests/unit
were given execute permission by mistake
in Change-Id: I29020058671348e0734906a71ac3ae0798172a23.
This proposal want to remove the error permission.
Change-Id: I7e6466f8e9a0886e293df3f229d03a49b6fc92cc
Related-Id: I29020058671348e0734906a71ac3ae0798172a23
Partial-Bug: #1259292
This two files were given execution permission
by mistake. This patch removes the error permission.
Change-Id: I15a6b9fc6af23d9fa1348d567daacca9e19fd7ee
Replace assertEqual(None, *) with assertIsNone in tests to have more
clear messages in case of failure.
Trivafix.
Change-Id: If581190485435b5163bc3db264ccd6c0bf1df843
In a scenario, where network is a part of multiple
l2-gateway-connections, retain ucast_macs_remote entries
in ovsdb until the last l2-gateway-connection is deleted
for that network.
Change-Id: I6d63c5ff0c3c9d208612eeec25351977a40820c0
Closes-Bug: 1607399
The patche does the following:
1. remove nested with calls from unit tests
2. updates tox.ini to enable us to use the \ at the end
of a line
3. All integers in python 3 are long.
4. Python 3 does not support __builtin__. Removed it from the tests.
Now the unit tests pass when running python 3.
This also adds support to tox.
Change-Id: Iacbf0c2c05248819af817109e7dd637f71c82404
In DVR mode no host IP is associated with the L3 Agent because
the router is configured on all the Compute Nodes and on the Network Node.
To overcome this problem we look for L3 Agent that is running on the Network Node,
resolve the hostname of the Network Node to get its IP address and use it to
configure the destination IP needed for neutron port location information.
Closes-Bug: 1463784
Change-Id: I2595c714ede896baa7726ceec793de9a7a29e6b2
Some tests used incorrect order assertEqual(observed, expected).
The correct order expected by testtools is
assertEqual(expected, observed).
Co-Authored-By: yan.songming@zte.com.cn
Change-Id: I29020058671348e0734906a71ac3ae0798172a23
Partial-Bug: #1259292
Change-Id: I06912522a1e8ccf7a93357d6ee2ab54e02daaf68
Fix unit test problem
unit test failed due to missing mock.
Change-Id: I656ed3518a763750c37ad995f5016d53b63388ac
whenever l2gateway_agnet.ini is reconfigured to the same ovsdb identifier
but different IP, then we need to clean the mysql db entries from earlier
configured ovsdb_identifier and IP.
For Ex: l2gateway_agent is connected to "ovsdb1:10.10.10.10:6632",
but when you change l2gateway_agent.ini to "ovsdb1:20.20.20.20:6632",
then the mysql entries related to "ovsdb1:10.10.10.10:6632" should be cleaned.
Change-Id: I72cd5a5e2ea27c2a6b37865c3517e614f901aecf
Closes-Bug:1588809
ovsdb server will initiate SSL connection to l2gateway agent, whenever
ovsdb manager table is populated with l2gateway agent IP with SSL.
This patch set will handle the ssl connection in the l2gw agent side.
Change-Id: I63f1f0465fdcbdc9ed6be0d98fb8e5b59e882eb0
Closes-Bug: 1585901
whenever l2gw agent IP:PORT is configured in manager table
of ovsdb server, it has to be configured in l2gateway_agent.ini
so that l2gw agent can listen for the connection request from ovsdb
server for the configured port.
Change-Id: Iac81c41cbac7daf43e72c12f094d6fefe33ce749
Closes-Bug: 1580869
for insert/delete vlan_bindings column in physical_port table.
updating the vlan_bindings, which requires the previous data
from neutron db for a port, which is a overhead operation,and also causing
inconsistent entries in ovsdb server.
use mutate operation so that only the vlan_bindings which is generated
in request is inserted/deleted by mutating the vlan_binding column.
so that vlan_bindings in ovsdb is consistent.
Closes-Bug: 1542185
Change-Id: I8e0d3c19f74ae2906236fd71befacc0ff501023a
networking-vsphere, which works for ESXi nodes
does not support l2 population. so choosing
ovs-vapp agent instead of ovs agent to create tunnel
by tunnel sync call, while creating l2-gateway-connection.
Closes-Bug: 1544112
Change-Id: I801e539ccc4f9bdce3b829189c97c53ba84a8f48
Enhance the L2GW Service Driver framework to embrace
out-of-L2GW-source-tree service drivers.
Co-Authored-By: Vivekanandan Narasimhan <n.vivekanandan@ericsson.com>
Closes-Bug:1532436
Change-Id: Ib56ee8bfd182c031e468c503acb0cd75daea8c40
check for interface type while creating l2-gateway.
it should be list of dict.if not raise an appropriate message.
for ex: request body for l2-gateway-create is as below.
{"l2_gateway": {"name": "gw2", "devices": [{"interfaces": [{"name": "i1"}]}, "device_name": "switch2"}]}'
Change-Id: I65430efa1a3ed4416e649f0377d9dff7fafc5b57
Closes-Bug: 1548361
The patch set fixes a problem where the L2gw agent requires a restart
when a user adds the Management IP of the L2gw agent in the Manager
table of a new OVSDB server.
Closes-Bug:1546891
Change-Id: I39c87f3021fd0091e7f49f8f3d22c67ebffb0306
while retreving the information from port details which belongs to specific host,
we are checking whether ovs agent is running on that host or not. if not,
exception is raised saying ovs agent not found in the host.
Closes-Bug:1515877
Change-Id: I23fccd8751ce791e1c6fd6920a0510c943714126
Since l2gateway binds vxlan(virtual side) to vlan(physical side) segment.
We are extracting only vxlan segment from the virtual network.
Since multi segment network can have multiple segmentation id's belonging
to different network types(vlan, gre, vxlan, etc), we are extracting the
vxlan segment from it.
We are checking for multiple vxlan segments in the network since ovsdb
does not allow multiple vxlan segmentation id's to associate for same
vlan (physical side) while creating l2_gateway_connection.
For Ex: say multi segment network has two vxlan segment id's 1000 and 2000.
If we create a l2_gateway_connection for this network by providing physical
side vlan segment as 500, the bindings should be 1000:500 and 2000:500,
this is not allowed in ovsdb hardware vtep schema.
Closes-Bug:1511639
Change-Id: I5f704eaf40763686aa30320dff7a99a16b6c1772
The patch set provides a framework to support
service drivers so that the south bound implementation
need not be tied to only the L2gw agent communicating
over the RabbitMQ message bus. This will help to support
other types of south bound implementations like OpenDaylight.
Change-Id: I403c7c0f110d4ad95d803640508b78c1539d181f
Closes-Bug: 1478812
Author: Maruti <maruti.kamat@hp.com>
Co-Authored-By: Manjunath Patil <mpatil@hp.com>
ovsdb server initiates the connection to l2gw agent with the entries in
manager table in ovsdb hardware vtep schema and with flag 'enable_manager'
set to True in l2gateway_agent.ini.
multiple ovsdb can connect to same l2gatway agent with the l2gw agent ip in
respective manager table.
This patchset addresses the handling of connections from multiple
ovsdb servers.
Change-Id: Iffe6a9e8599ffaed55c3f8b749c4d6f7d0e52c79
Closes-Bug:1495005
ovsdb server initiates the connection to l2gw agent with the entries in
manager table in ovsdb hardware vtep schema.
A configurable option 'enable_manager' in .ini file is provided so that
the connection can be initiated by the ovsdb server or not based on boolean
value.
By default 'enable_manager' value is False, turn on the variable to True
to initiate the connection from ovsdb server to l2gw agent.
Closes-Bug:1466302
Change-Id: Ib668ecda381367ea9f2f3cfa45e63d0e91e48f33
This patchset implements the UcastMacRemote deletion after
the corresponding switch is deleted or disconnected from the
OVSDB.
Change-Id: I383412b523d7c96b85735e18202450edf71fc6f1
Closes-Bug:1453736
The logical switch table has to be deleted when the
last switch from the ovsdb is deleted. This patch
implements the same.
Change-Id: I256d12437e73f213c9e33fdfd1d2482a625f8607
Closes-Bug:1453097
This fixes the unit tests.
To get jenkins to pass we also need to comment out the migration
check for pep8 temporarily. This check will be re-enabled with
https://review.openstack.org/205866
Change-Id: If8484812e7cd026727b920fa70182db23154df58
There were calls to non-existent assert's that were silently passing;
there a number of tests that were poorly mocked and have been fixed.
Other tests were clearly just change detector and were removed altogether.
Change-Id: I66ca5140a2dfcb57bf074a7f6d33b97d34cd968b
checking mac and logical switch while creating l2-gateway-connection,
if there is entry in ucast_mac_remote for second l2-gateway-connection for
same logical switch.
taken care of deleting ucast_mac_remote and vlan_bindings
while deleting l2-gateway-connection.
Closes-Bug:1447910
Co-Authored-By: Phani Pawan <ppawan@hp.com>
Co-Authored-By: MANJUNATH PATIL <mpatil@hp.com>
Change-Id: Id9205c902210d94d7168eb95fbd6c3520fbb6239
internal server error occurs if empty l2gateway is passed in
_check_port_fault_status_and_switch_fault_status.so checking the the same.
Closes-Bug: 1454670
Change-Id: I5faba8d5e097b5ca8aeec44b7fde0a61d98486e4
The patch set handles recreation of tunnels
when openvswitch is restarted and it also proposes
the fix for exception thrown while adding vm port
after l2gateway connection to ovsdb
Closes-Bug:1452192
Closes-Bug:1452149
Change-Id: I3ccdd64272adc2d008da69fdd2652b029368fb44
Co-Authored-By: Phani Pawan <ppawan@hp.com>
The patch set fixes the problem described in a launchpad
bug, where any failures in inserting/updating/delete MACs
into the OVSDB server do not get retried in a later
point in time. The failure may occur when the L2 gateway
agent is down or the OVSDB server is down.
Change-Id: I79956f498c3279e1c78be812563a32c2c41e77ca
Closes-Bug: 1446805
Closes-Bug: 1451765
This patchset addresses the changes where deactivating
switch/ovsdb should delete l2-gateway-connections.
Change-Id: I8be62153e24696c4b265b7634ab172fbd4a2bda5
Closes-bug: 1447453
Creating l2-gateway-connection gives internal
server error if invalid device or invalid interface
is specified.
Change-Id: I5a738b085400b3937dd4f03076233853d05133d0
Closes-bug: 1447467
LiuYong