[OVN] Update check_for_mcast_flood_reports() to check for mcast_flood

The patch [0] changed the value of the "mcast_flood" option for the
localnet ports in OVN to "false" to avoid multicast packet duplication
but, the maintenance task check_for_mcast_flood_reports() was never
updated to account for that change.

So, localnet ports created prior to [0] would continue to have the
"mcast_flood" value as "true" and new ports would have it as "false".
This patch fixes the maintenance task.

[0] https://review.opendev.org/c/openstack/neutron/+/797418

(cherry picked from Neutron d02fb560aa35c4931d40000e8ca4c0e4105299b7)

Closes-Bug: #1949081
Signed-off-by: Lucas Alvares Gomes <lucasagomes@gmail.com>
Change-Id: I9b16a2772a547e6aed1febd481b2ef1f67f1ce37

networking_ovn/common/maintenance.py

@@ -646,7 +646,7 @@ class DBInconsistenciesPeriodics(SchemaAwarePeriodicsBase):
                     txn.add(cmd)
         raise periodics.NeverAgain()
 
-    # TODO(lucasagomes): Remove this in the Y cycle
+    # TODO(lucasagomes): Remove this in the Z cycle
     # A static spacing value is used here, but this method will only run
     # once per lock due to the use of periodics.NeverAgain().
     @periodics.periodic(spacing=600, run_immediately=True)
@@ -661,13 +661,16 @@ class DBInconsistenciesPeriodics(SchemaAwarePeriodicsBase):
                 continue
 
             options = port.options
-            if ovn_const.LSP_OPTIONS_MCAST_FLOOD_REPORTS in options:
-                continue
-
-            options.update({ovn_const.LSP_OPTIONS_MCAST_FLOOD_REPORTS: 'true'})
             if port_type == ovn_const.LSP_TYPE_LOCALNET:
+                mcast_flood_value = options.get(
+                    ovn_const.LSP_OPTIONS_MCAST_FLOOD_REPORTS)
+                if mcast_flood_value == 'false':
+                    continue
                 options.update({ovn_const.LSP_OPTIONS_MCAST_FLOOD: 'false'})
+            elif ovn_const.LSP_OPTIONS_MCAST_FLOOD_REPORTS in options:
+                continue
 
+            options.update({ovn_const.LSP_OPTIONS_MCAST_FLOOD_REPORTS: 'true'})
             cmds.append(self._nb_idl.lsp_set_options(port.name, **options))
 
         if cmds:

networking_ovn/tests/unit/common/test_maintenance.py

@@ -400,7 +400,8 @@ class TestDBInconsistenciesPeriodics(db_base.DBTestCase,
         nb_idl = self.fake_ovn_client._nb_idl
         lsp0 = fakes.FakeOvsdbRow.create_one_ovsdb_row(
             attrs={'name': 'lsp0',
-                   'options': {'mcast_flood_reports': 'true'},
+                   'options': {
+                       constants.LSP_OPTIONS_MCAST_FLOOD_REPORTS: 'true'},
                    'type': ""})
         lsp1 = fakes.FakeOvsdbRow.create_one_ovsdb_row(
             attrs={'name': 'lsp1', 'options': {}, 'type': ""})
@@ -415,21 +416,33 @@ class TestDBInconsistenciesPeriodics(db_base.DBTestCase,
                    'type': "router"})
         lsp5 = fakes.FakeOvsdbRow.create_one_ovsdb_row(
             attrs={'name': 'lsp5', 'options': {}, 'type': 'localnet'})
+        lsp6 = fakes.FakeOvsdbRow.create_one_ovsdb_row(
+            attrs={'name': 'lsp6',
+                   'options': {
+                       constants.LSP_OPTIONS_MCAST_FLOOD_REPORTS: 'true',
+                       constants.LSP_OPTIONS_MCAST_FLOOD: 'true'},
+                   'type': 'localnet'})
+        lsp7 = fakes.FakeOvsdbRow.create_one_ovsdb_row(
+            attrs={'name': 'lsp7',
+                   'options': {
+                       constants.LSP_OPTIONS_MCAST_FLOOD_REPORTS: 'true',
+                       constants.LSP_OPTIONS_MCAST_FLOOD: 'false'},
+                   'type': 'localnet'})
 
         nb_idl.lsp_list.return_value.execute.return_value = [
-            lsp0, lsp1, lsp2, lsp3, lsp4, lsp5]
+            lsp0, lsp1, lsp2, lsp3, lsp4, lsp5, lsp6, lsp7]
 
         # Invoke the periodic method, it meant to run only once at startup
         # so NeverAgain will be raised at the end
         self.assertRaises(periodics.NeverAgain,
                           self.periodic.check_for_mcast_flood_reports)
 
-        # Assert only lsp1 and lsp5 were called because they are the only
-        # ones meeting the criteria ("mcast_flood_reports" not yet set,
-        # and type "" or localnet)
+        # Assert only lsp1, lsp5 and lsp6 were called because they are the
+        # only ones meeting the criteria
         expected_calls = [
             mock.call('lsp1', mcast_flood_reports='true'),
-            mock.call('lsp5', mcast_flood_reports='true', mcast_flood='false')]
+            mock.call('lsp5', mcast_flood_reports='true', mcast_flood='false'),
+            mock.call('lsp6', mcast_flood_reports='true', mcast_flood='false')]
 
         nb_idl.lsp_set_options.assert_has_calls(expected_calls)