openstack
/
neutron-dynamic-routing
Code Issues Proposed changes

Update patch set 21 

Patch Set 21: Code-Review-1

(4 comments)

Patch-set: 21
Reviewer: Gerrit User 13252 <13252@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Label: Code-Review=-1
Attention: {"person_ident":"Gerrit User 33273 \u003c33273@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"Dr. Jens Harbott (frickler) replied on the change"}
This commit is contained in:
Gerrit User 13252 2021-10-25 15:20:30 +00:00 committed by Gerrit Code Review
parent cedeba56ed
commit 3317fcef96
1 changed files with 78 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

78
930b26afbcfcae44a92b96f7a6c2dad1c3857bbf Normal file
View File

@ -0,0 +1,78 @@
{
"comments": [
{
"unresolved": true,
"key": {
"uuid": "ab7d8484_6be26e83",
"filename": "neutron_dynamic_routing/db/bgp_db.py",
"patchSetId": 21
},
"lineNbr": 78,
"author": {
"id": 13252
},
"writtenOn": "2021-10-25T15:20:30Z",
"side": 1,
"message": "Why should the association be bound to a specific project? Wouldn\u0027t the project from the router be enough identification if needed?\n\nI even wonder why the ID is needed. Can there be multiple associations between the same speaker and router?",
"revId": "930b26afbcfcae44a92b96f7a6c2dad1c3857bbf",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "a5848cb1_67c6a1dc",
"filename": "neutron_dynamic_routing/db/migration/alembic_migrations/versions/xena/expand/738d0ae1984e_bgpaas_enh.py",
"patchSetId": 21
},
"lineNbr": 0,
"author": {
"id": 13252
},
"writtenOn": "2021-10-25T15:20:30Z",
"side": 1,
"message": "The migration could only land in yoga now.",
"revId": "930b26afbcfcae44a92b96f7a6c2dad1c3857bbf",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "4fa66b95_eb4b979f",
"filename": "neutron_dynamic_routing/db/migration/alembic_migrations/versions/xena/expand/738d0ae1984e_bgpaas_enh.py",
"patchSetId": 21
},
"lineNbr": 40,
"author": {
"id": 13252
},
"writtenOn": "2021-10-25T15:20:30Z",
"side": 1,
"message": "How about doing cascade_on_delete on these?",
"range": {
"startLine": 37,
"startChar": 7,
"endLine": 40,
"endChar": 63
},
"revId": "930b26afbcfcae44a92b96f7a6c2dad1c3857bbf",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "dbfca762_19e2b48d",
"filename": "neutron_dynamic_routing/tests/unit/db/test_bgp_db.py",
"patchSetId": 21
},
"lineNbr": 53,
"author": {
"id": 13252
},
"writtenOn": "2021-10-25T15:20:30Z",
"side": 1,
"message": "Can a speaker only be associated to a single router? Otherwise better use a list of IDs like for networks and peers.",
"revId": "930b26afbcfcae44a92b96f7a6c2dad1c3857bbf",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}